Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Alexander Egorenkov <egorenar@linux.ibm.com>
Cc: yann.morin.1998@free.fr, aduskett@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/prelink-cross: fix handling of TLS offsets for s390 arch
Date: Sun, 8 Aug 2021 22:39:21 +0200	[thread overview]
Message-ID: <20210808223921.5ff7c8b0@windsurf> (raw)
In-Reply-To: <20210808094844.385703-1-egorenar@linux.ibm.com>

On Sun,  8 Aug 2021 11:48:44 +0200
Alexander Egorenkov <egorenar@linux.ibm.com> wrote:

> /tmp/instance-1/output-1/host/sbin/prelink-rtld: error while loading
> shared libraries: /lib64/libc.so.6: cannot handle TLS data
> ERROR: can't resolve libraries to shared libraries: glib-2.0, gobject-2.0
> ninja: build stopped: subcommand failed.
> make: *** [package/pkg-generic.mk:270:
> /tmp/instance-1/output-1/build/gobject-introspection-1.68.0/.stamp_built]
> Error 1
> make: Leaving directory '/tmp/instance-1/buildroot'

Thanks a lot for having looked at this problem and submitted a patch. I
have applied, after adjusting a bit the commit log, see below.

> 
> Fixes:
> - http://autobuild.buildroot.org/?reason=gobject-introspection-1.68.0&arch=s390x

This is not a correct way to reference an autobuilder failure. Indeed,
this point to a list of failures, which today are what you are fixing,
but tomorrow? Maybe there will be another s390 failure in
gobject-introspection, which is different. This would cause anybody
look at your commit log and following the link to be very confused. So
we always point to one (or several) specific build failures.

> Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> ---
>  ...c-Fix-TLS-offsets-computation-for-s3.patch | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 package/prelink-cross/0001-src-rtld-dl-tls.c-Fix-TLS-offsets-computation-for-s3.patch

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-08 20:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-08  9:48 [Buildroot] [PATCH 1/1] package/prelink-cross: fix handling of TLS offsets for s390 arch Alexander Egorenkov
2021-08-08 20:39 ` Thomas Petazzoni [this message]
2021-09-04 19:54 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210808223921.5ff7c8b0@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=aduskett@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=egorenar@linux.ibm.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox