From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/ffmpeg: add -latomic to pkg-config files
Date: Mon, 9 Aug 2021 09:31:24 +0200 [thread overview]
Message-ID: <20210809093124.7717b224@windsurf> (raw)
In-Reply-To: <CAPi7W83WV+dAkbdi8idtja67YbQ1C=LDeQkNGZSpBkp_d=kwoQ@mail.gmail.com>
On Sun, 8 Aug 2021 23:30:28 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Applied to master, thanks. Why do you consider the patch not acceptable
> > upstream?
> Because I think it only makes sense because we're passing -latomic to
> extralibs but I can try to get their feedback.
I think it does. If you pass extra libraries to link against, then the
.so files are linked against them. In a dynamic linking environment,
that's sufficient. But in a static linking environment, that requires
your .pc file having a Libs.private pointing to those extra libraries.
So I think there's an argument in favor of this, but only if those
extra libraries are added to Libs.private in the .pc file, not Libs.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-08-09 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 19:40 [Buildroot] [PATCH v2, 1/1] package/ffmpeg: add -latomic to pkg-config files Fabrice Fontaine
2021-08-08 21:22 ` Thomas Petazzoni
2021-08-08 21:30 ` Fabrice Fontaine
2021-08-09 7:31 ` Thomas Petazzoni [this message]
2021-09-04 20:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809093124.7717b224@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=mahyar.koshkouei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox