From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Asaf Kahlon <asafka7@gmail.com>
Cc: "Raphaël Mélotte" <raphael.melotte@mind.be>,
buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/python-pymupdf: depend on python3
Date: Sat, 14 Aug 2021 15:49:33 +0200 [thread overview]
Message-ID: <20210814154933.022a1bda@windsurf> (raw)
In-Reply-To: <CALFsTFUWc=g0X1wJUpc9-DyhwcdoT3DzH1DMiho-hfekmeROug@mail.gmail.com>
Hello Asaf,
On Sat, 14 Aug 2021 09:04:39 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:
> > This dependency should have been propagated to the two Config.in
> > comments in that file, so that they don't appear if Python3 is not
> > used. I fixed that up and applied to master. Thanks!
>
> Hmm that's interesting...
> I agree it's needed but from a quick look I think we have packages
> which don't do that (for example - txtorcon. If the toolchain doesn't
> support C++, we will see the "comment" part under the python2 external
> modules menu although python3 is needed).
> Do I miss something or is it a real mistake?
Indeed, python-txtorcon/Config.in is also wrong. Imagine the user: he
has python2 enabled, and see "python-XYZ needs a toolchain w/ C++", so
he goes ahead and enables C++. Back to the Python menu.. the comment
has disappeared, but there is still no option to enable python-XYZ
because the option depends on Python 3.x. It would be very confusing,
so we definitely want to hide the Config.in comment with a "depends on
BR2_PACKAGE_PYTHON3" in this case.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-14 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 7:36 [Buildroot] [PATCH 1/1] package/python-pymupdf: depend on python3 Asaf Kahlon
2021-08-13 13:04 ` Thomas Petazzoni
2021-08-14 6:04 ` Asaf Kahlon
2021-08-14 13:49 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210814154933.022a1bda@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=raphael.melotte@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox