From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/sentry-cli: remove package
Date: Thu, 19 Aug 2021 22:50:21 +0200 [thread overview]
Message-ID: <20210819205021.GE27036@scaer> (raw)
In-Reply-To: <20210818202212.684857-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2021-08-18 22:22 +0200, Thomas Petazzoni spake thusly:
> This package has had build failures for a very long time, and these
> issues have not been fixed, and it is now the number 1 build failure
> reason in our autobuilders. It is time to acknowledge that the package
> needs to be removed.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Indeed, this is a bit sad that we have to remove a package, but since
noone ever fixed the issues with it, meh...
I was pondering whether it was material for master or next, but then I
decided master, because we do not want a release with a known-broken,
never-to-be-fixed package.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> DEVELOPERS | 1 -
> package/Config.in.host | 1 -
> package/sentry-cli/Config.in.host | 10 ----------
> package/sentry-cli/sentry-cli.hash | 3 ---
> package/sentry-cli/sentry-cli.mk | 32 ------------------------------
> 5 files changed, 47 deletions(-)
> delete mode 100644 package/sentry-cli/Config.in.host
> delete mode 100644 package/sentry-cli/sentry-cli.hash
> delete mode 100644 package/sentry-cli/sentry-cli.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index af97de02de..64cd29d7d1 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1441,7 +1441,6 @@ F: package/python-schedule/
> F: package/python-sentry-sdk/
> F: package/python-websockets/
> F: package/python-xlib/
> -F: package/sentry-cli/
> F: package/sentry-native/
> F: package/unclutter-xfixes/
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 8d443ea255..551352482e 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -79,7 +79,6 @@ menu "Host utilities"
> source "package/s6-rc/Config.in.host"
> source "package/sam-ba/Config.in.host"
> source "package/sdbusplus/Config.in.host"
> - source "package/sentry-cli/Config.in.host"
> source "package/squashfs/Config.in.host"
> source "package/sunxi-tools/Config.in.host"
> source "package/swig/Config.in.host"
> diff --git a/package/sentry-cli/Config.in.host b/package/sentry-cli/Config.in.host
> deleted file mode 100644
> index 3124015367..0000000000
> --- a/package/sentry-cli/Config.in.host
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -config BR2_PACKAGE_HOST_SENTRY_CLI
> - bool "host sentry-cli"
> - depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> - select BR2_PACKAGE_HOST_RUSTC
> - help
> - Official Sentry command line interface
> -
> - For managing debug information files and source maps.
> -
> - https://docs.sentry.io/cli/
> diff --git a/package/sentry-cli/sentry-cli.hash b/package/sentry-cli/sentry-cli.hash
> deleted file mode 100644
> index 3b0733a276..0000000000
> --- a/package/sentry-cli/sentry-cli.hash
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -# locally calculated
> -sha256 5d0f7acf6a139d1c1716b9a8ff76c8bfaab09104ba663c957bb9a5dba2ffbabd sentry-cli-1.57.0.tar.gz
> -sha256 9503def7b54ceb6e3cd182fd59bc05d3a30d7eae481e65aaba4b495133c83c14 LICENSE
> diff --git a/package/sentry-cli/sentry-cli.mk b/package/sentry-cli/sentry-cli.mk
> deleted file mode 100644
> index 7e53f16026..0000000000
> --- a/package/sentry-cli/sentry-cli.mk
> +++ /dev/null
> @@ -1,32 +0,0 @@
> -################################################################################
> -#
> -# sentry-cli
> -#
> -################################################################################
> -
> -SENTRY_CLI_VERSION = 1.57.0
> -SENTRY_CLI_SITE = $(call github,getsentry,sentry-cli,$(SENTRY_CLI_VERSION))
> -SENTRY_CLI_LICENSE = BSD-3-clause
> -SENTRY_CLI_LICENSE_FILES = LICENSE
> -
> -HOST_SENTRY_CLI_DEPENDENCIES = host-rustc host-zlib
> -
> -HOST_SENTRY_CLI_CARGO_ENV = \
> - CARGO_HOME=$(HOST_DIR)/share/cargo \
> - RUSTFLAGS="$(addprefix -C link-args=,$(HOST_LDFLAGS))"
> -
> -HOST_SENTRY_CLI_CARGO_OPTS = \
> - --release \
> - --manifest-path=$(@D)/Cargo.toml
> -
> -define HOST_SENTRY_CLI_BUILD_CMDS
> - $(HOST_MAKE_ENV) $(HOST_SENTRY_CLI_CARGO_ENV) \
> - cargo build $(HOST_SENTRY_CLI_CARGO_OPTS)
> -endef
> -
> -define HOST_SENTRY_CLI_INSTALL_CMDS
> - $(INSTALL) -D -m 0755 $(@D)/target/release/sentry-cli \
> - $(HOST_DIR)/bin/sentry-cli
> -endef
> -
> -$(eval $(host-generic-package))
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-19 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 20:22 [Buildroot] [PATCH] package/sentry-cli: remove package Thomas Petazzoni
2021-08-18 20:36 ` Adam Duskett
2021-08-18 21:54 ` Thomas Petazzoni
2021-08-19 16:08 ` Adam Duskett
2021-08-19 16:19 ` Thomas Petazzoni
2021-08-19 16:30 ` Adam Duskett
2021-08-19 17:56 ` Thomas Petazzoni
2021-08-19 20:50 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819205021.GE27036@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=joseph.kogut@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox