Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl"
Date: Thu, 19 Aug 2021 22:51:18 +0200	[thread overview]
Message-ID: <20210819225118.361fe904@windsurf> (raw)
In-Reply-To: <20210817221530.2343233-1-fontaine.fabrice@gmail.com>

On Wed, 18 Aug 2021 00:15:30 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
> libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
> conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
> will never be triggered. Moreover, libressl provides a pkg-config file.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libshout/libshout.mk | 3 ---
>  1 file changed, 3 deletions(-)

I've applied to master, because you're right, what
46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
being 'y'.

However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-19 20:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 22:15 [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl" Fabrice Fontaine
2021-08-19 20:51 ` Thomas Petazzoni [this message]
2021-08-19 20:57   ` Fabrice Fontaine
2021-08-19 21:09     ` Yann E. MORIN
2021-08-19 21:12     ` Thomas Petazzoni
2021-08-19 21:15       ` Fabrice Fontaine
2021-09-06 13:40 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210819225118.361fe904@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox