From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Mahyar Koshkouei <mahyar.koshkouei@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/1] package/mpv: vaapi-drm needs egl-drm
Date: Fri, 20 Aug 2021 10:03:20 +0200 [thread overview]
Message-ID: <20210820080320.GO27036@scaer> (raw)
In-Reply-To: <20210819221254.23336-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-08-20 00:12 +0200, Fabrice Fontaine spake thusly:
> Build of vaapi-drm without egl-drm is broken since commit
> 6ec47c4e59c7c8c57e972dab985c8a2ba0bf7174.
>
> egl-drm has been added with commit
> 031df474c24f92757ac95ade572b90995ebdc6a2 and it is only available with
> mesa3d because of the gbm dependency:
> https://github.com/mpv-player/mpv/blob/0b56e1c00a57fdb767674462c299a5c973a9e373/wscript#L571
>
> Indeed, at the moment, mesa3d is the only gbm provider in buildroot.
>
> Fixes:
> - http://autobuild.buildroot.org/results/83d6dcbb77ab8754aefcdcf90baeaff9db2a1c81
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
> - Update commit message
>
> package/mpv/mpv.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/mpv/mpv.mk b/package/mpv/mpv.mk
> index d4d4d4811d..91e31dd150 100644
> --- a/package/mpv/mpv.mk
> +++ b/package/mpv/mpv.mk
> @@ -181,7 +181,7 @@ endif
> ifeq ($(BR2_PACKAGE_LIBVA)$(BR2_PACKAGE_MPV_SUPPORTS_VAAPI),yy)
> MPV_CONF_OPTS += --enable-vaapi
> MPV_DEPENDENCIES += libva
> -ifeq ($(BR2_PACKAGE_LIBDRM),y)
> +ifeq ($(BR2_PACKAGE_LIBDRM)$(BR2_PACKAGE_MESA3D_OPENGL_EGL),yy)
> MPV_CONF_OPTS += --enable-vaapi-drm
> else
> MPV_CONF_OPTS += --disable-vaapi-drm
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-20 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 22:12 [Buildroot] [PATCH v2,1/1] package/mpv: vaapi-drm needs egl-drm Fabrice Fontaine
2021-08-20 8:03 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820080320.GO27036@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=mahyar.koshkouei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox