From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Titouan Christophe <titouanchristophe@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libvirt: fix syntax error in Config.in
Date: Fri, 20 Aug 2021 18:01:42 +0200 [thread overview]
Message-ID: <20210820160142.GQ27036@scaer> (raw)
In-Reply-To: <20210820101747.193382-1-titouanchristophe@gmail.com>
Titouan, All,
On 2021-08-20 12:17 +0200, Titouan Christophe spake thusly:
> The typo was introduced in 6aa318d91e66731d66dca485c4c30391fe0e2423
I double- and triple-checked the truth table of the condition, but it
was obviously too late for me to at least try a menuconfig before
pushing (actually I tried, but my vim buffer was not saved, so the
menuconfig succeeded, *before* my change, meh...)
> Signed-off-by: Titouan Christophe <titouanchristophe@gmail.com>
Applied to master, thanks for fixing my mess!
Regards,
Yann E. MORIN.
> ---
> package/libvirt/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 9308d2a6ac..8c3021242a 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -9,7 +9,7 @@ comment "libvirt needs udev /dev management, a toolchain w/ threads, dynamic lib
> depends on BR2_PACKAGE_LIBVIRT_ARCH_SUPPORTS
> depends on !BR2_PACKAGE_HAS_UDEV || BR2_STATIC_LIBS || !BR2_USE_MMU || \
> !BR2_TOOLCHAIN_HAS_THREADS || \
> - !(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 &&
> + !(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 && \
> (BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_11 || !BR2_aarch64))
>
> config BR2_PACKAGE_LIBVIRT
> --
> 2.32.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-08-20 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 10:17 [Buildroot] [PATCH 1/1] package/libvirt: fix syntax error in Config.in Titouan Christophe
2021-08-20 16:01 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820160142.GQ27036@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=titouanchristophe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox