Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Matthew Weber via buildroot <buildroot@busybox.net>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Matthew Weber <matthew.weber@collins.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/kvm-unit-tests: disable SSP
Date: Fri, 20 Aug 2021 23:22:58 +0200	[thread overview]
Message-ID: <20210820232258.144f2fda@windsurf> (raw)
In-Reply-To: <20210820133232.40519-1-matthew.weber@collins.com>

Hello Matt,

On Fri, 20 Aug 2021 08:32:32 -0500
Matthew Weber via buildroot <buildroot@busybox.net> wrote:

> kvm-unit-tests shouldn't use stack-protector as the test suite is
> building free standing binaries to test QEMU. There is no guarantee
> that GCC has set a spec to filter out stack protector enabling with
> -ffreestanding so disabling explicitly to prevent a series of build
> failures.
> 
> Fixes:
> http://autobuild.buildroot.net/results/780/780c8c70ea7015113714cbd3841d96b08bd2f2aa/
> 
> Signed-off-by: Matthew Weber <matthew.weber@collins.com>
> ---
>  package/kvm-unit-tests/kvm-unit-tests.mk | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)

Thanks, but your patch doesn't apply to the master branch, and it makes
me think we're piling up work-arounds on work-arounds.

Indeed, the passing of -fno-stack-protector in EXTRA_CFLAGS has been
removed in master as of commit
d183146b5c7a1a8d1a3c828bd3b6d0660d97efc0, which itself says it is no
longer needed since commit 0788e921f961e36a50a94f8bb98f7eb75b312245.

However, it seems like despite
0788e921f961e36a50a94f8bb98f7eb75b312245, SSP is still being used.

Matt, Fabrice, could you review the situation and see what is the
correct fix moving forward ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-20 21:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 13:32 [Buildroot] [PATCH] package/kvm-unit-tests: disable SSP Matthew Weber via buildroot
2021-08-20 21:22 ` Thomas Petazzoni [this message]
2021-08-20 22:04   ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210820232258.144f2fda@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=fontaine.fabrice@gmail.com \
    --cc=matthew.weber@collins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox