Re: [Buildroot] [PATCH v3 05/16] qt5: Fix sporadic build failure during top-level parallel build

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Hervé, All, 

On 2021-08-28 18:38 +0200, Yann E. MORIN spake thusly:
> On 2021-08-17 10:39 +0200, Herve Codina spake thusly:
> > From: Andreas Naumann <anaumann@ultratronik.de>
> > 
> > When using top level parallel build, independent qt5 packages may be
> > built in parallel. Because of their staging dirs being hardlinked, they
> > all use the same qt.conf file to manipulate during configure, while
> > another qt5 package might already use it. This leads to weird build failures
> > because the folders qmake is using are diverted in erratic ways.
> > Fix this by actually recreating a non-shared qt.conf file for every package.
> 
> But with patch 10 (Makefile: breaks hardlinks in global {TARGET,
> HOST}_DIR on per-package build), is this patch 5 still needed?
> 
> IIUC, patch 10 makes the per-package directories actual copies rather
> than hardlinks, so the per-package host directory is a complete copy,
> thus this qt.conf is no longer a hardlink...
> 
> Did I miss something?

Yes, I missed that patch 10 is not about assembling the per-package
directories from their dependencies, but to gather those per-package
directories to assemble the final target/ and host/.

So, yes, this qt5.conf patch is still needed.

Regards,
Yann E. MORIN.

> Regards,
> Yann E. MORIN.
> 
> > Signed-off-by: Andreas Naumann <anaumann@ultratronik.de>
> > Reviewed-by: Herve Codina <herve.codina@bootlin.com>
> > ---
> > New patch in this v3 series
> > 
> > This patch was previously send by Andreas Naumann.
> > https://lore.kernel.org/buildroot/20210623083927.8278-1-anaumann@ultratronik.de/
> > https://lore.kernel.org/buildroot/b1d0c5a5-f76f-e38e-0257-1300f6a30eab@andin.de/
> > As this patch makes sense in this series, it was integrated in this v3 version.
> > 
> >  package/qt5/qt5.mk | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/package/qt5/qt5.mk b/package/qt5/qt5.mk
> > index db6ccd2b42..3ffb7b0063 100644
> > --- a/package/qt5/qt5.mk
> > +++ b/package/qt5/qt5.mk
> > @@ -15,6 +15,7 @@ include $(sort $(wildcard package/qt5/*/*.mk))
> >  # compiled into the Qt library. We need it to make "qmake" relocatable and
> >  # tweak the per-package install pathes
> >  define QT5_INSTALL_QT_CONF
> > +	rm -f $(HOST_DIR)/bin/qt.conf
> >  	sed -e "s|@@HOST_DIR@@|$(HOST_DIR)|" -e "s|@@STAGING_DIR@@|$(STAGING_DIR)|" \
> >  		$(QT5BASE_PKGDIR)/qt.conf.in > $(HOST_DIR)/bin/qt.conf
> >  endef
> > -- 
> > 2.31.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot