Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Woody Douglass <wdouglass@carnegierobotics.com>
Cc: "s.martin49@gmail.com" <s.martin49@gmail.com>,
	"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-cmake.mk: allow cmake packages to have a configurable install prefix
Date: Mon, 30 Aug 2021 23:16:33 +0200	[thread overview]
Message-ID: <20210830231633.6bbdcda9@windsurf> (raw)
In-Reply-To: <291e9206b766be40d6d9c49cc8d2ef388ca8f5d2.camel@carnegierobotics.com>

Hello Woody,

On Mon, 30 Aug 2021 19:47:56 +0000
Woody Douglass <wdouglass@carnegierobotics.com> wrote:

> I like to organize binaries on my system so that proprietary stuff
> is put under the /opt tree. this patch allows for that.
> 
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>

Can't you just pass:

<pkg>_CONF_OPTS = -DCMAKE_INSTALL_PREFIX=/opt

in your own package ?

<pkg>_CONF_OPTS is used as follows:

        $$($$(PKG)_CONF_ENV) $$(BR2_CMAKE) $$($$(PKG)_SRCDIR) \
                -DCMAKE_TOOLCHAIN_FILE="$$(HOST_DIR)/share/buildroot/toolchainfile.cmake" \
                -DCMAKE_INSTALL_PREFIX="/usr" \
                -DCMAKE_COLOR_MAKEFILE=OFF \
                -DBUILD_DOC=OFF \
                -DBUILD_DOCS=OFF \
                -DBUILD_EXAMPLE=OFF \
                -DBUILD_EXAMPLES=OFF \
                -DBUILD_TEST=OFF \
                -DBUILD_TESTS=OFF \
                -DBUILD_TESTING=OFF \
                -DBUILD_SHARED_LIBS=$$(if $$(BR2_STATIC_LIBS),OFF,ON) \
                $$(CMAKE_QUIET) \
                $$($$(PKG)_CONF_OPTS) \

Since it appears *after* -DCMAKE_INSTALL_PREFIX="/usr" I assume your
own -DCMAKE_INSTALL_PREFIX=/opt would take precedence.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-30 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 19:47 [Buildroot] [PATCH 1/1] package/pkg-cmake.mk: allow cmake packages to have a configurable install prefix Woody Douglass
2021-08-30 21:16 ` Thomas Petazzoni [this message]
2021-08-31 12:10   ` Woody Douglass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210830231633.6bbdcda9@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=s.martin49@gmail.com \
    --cc=wdouglass@carnegierobotics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox