Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Adam Duskett <aduskett@gmail.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Anisse Astier <anisse@astier.eu>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH/master 1/7] g-ir-scanner-qemuwrapper.in: Fix latent bug in
Date: Sat, 4 Sep 2021 00:27:29 +0200	[thread overview]
Message-ID: <20210904002729.60781355@windsurf> (raw)
In-Reply-To: <20210903162027.1935040-2-aduskett@gmail.com>

Hello Adam,

Thanks for this patch series!

On Fri,  3 Sep 2021 09:20:21 -0700
Adam Duskett <aduskett@gmail.com> wrote:

> If GIR_EXTRA_LIBS_PATH is empty, the LD_LIBRARY_PATH variable is
> ":.libs:$(dirname $0)/../lib:$(dirname $0)/../../lib".
> 
> As discussed with Yann Morin, add a new variable, "GOI_LIBRARY_PATH" and
> prepend ${GIR_EXTRA_LIBS_PATH:+${GIR_EXTRA_LIBS_PATH}:} to the path to fix the
> above bug.
> 
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

The commit title should have a prefix of
package/gobject-introspection/g-ir-scanner-qemuwrapper.in, and also a
description that isn't cut of in the middle.

These details can be fixed when applying, no need to resend for that.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-03 22:27 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 16:20 [Buildroot] [PATCH/master 0/7] Qemu and gobject-introspection fixes Adam Duskett
2021-09-03 16:20 ` [Buildroot] [PATCH/master 1/7] g-ir-scanner-qemuwrapper.in: Fix latent bug in Adam Duskett
2021-09-03 22:27   ` Thomas Petazzoni [this message]
2021-09-11 18:55   ` Arnout Vandecappelle
2021-09-03 16:20 ` [Buildroot] [PATCH/master 2/7] g-ir-scanner-qemuwrapper.in: Fix shellcheck warnings, switch to sh Adam Duskett
2021-09-11 18:57   ` Arnout Vandecappelle
2021-09-11 19:49     ` Yann E. MORIN
2021-09-03 16:20 ` [Buildroot] [PATCH/master 3/7] g-ir-scanner.in: " Adam Duskett
2021-09-11 19:00   ` Arnout Vandecappelle
2021-09-03 16:20 ` [Buildroot] [PATCH/master 4/7] g-ir-scanner-lddwrapper.in: " Adam Duskett
2021-09-11 19:00   ` Arnout Vandecappelle
2021-09-03 16:20 ` [Buildroot] [PATCH/master 5/7] g-ir-compiler.in: " Adam Duskett
2021-09-11 19:01   ` Arnout Vandecappelle
2021-09-03 16:20 ` [Buildroot] [PATCH/master 6/7] package/qemu: add BR2_PACKAGE_HOST_QEMU_USER_MODE_ARGS string Adam Duskett
2021-09-03 22:37   ` Thomas Petazzoni
2021-09-10 17:42     ` Adam Duskett
2021-09-11 19:39       ` Arnout Vandecappelle
2021-09-11 19:42         ` Arnout Vandecappelle
2021-09-03 16:20 ` [Buildroot] [PATCH/master 7/7] package/gobject-introspection: Add QEMU_USERMODE_ARGS support Adam Duskett
2021-09-11 19:47   ` Arnout Vandecappelle
2021-09-03 22:27 ` [Buildroot] [PATCH/master 0/7] Qemu and gobject-introspection fixes Thomas Petazzoni
2021-09-03 23:09   ` Adam Duskett
2021-09-04  7:49     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210904002729.60781355@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=aduskett@gmail.com \
    --cc=anisse@astier.eu \
    --cc=buildroot@buildroot.org \
    --cc=romain.naour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox