Re: [Buildroot] [PATCH 1/1] package/libtalloc: bump to version 2.3.3

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: David GOUARIN <dgouarin@gmail.com>
Cc: David GOUARIN <david.gouarin@thalesgroup.com>,
	Matt Weber <matthew.weber@collins.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libtalloc: bump to version 2.3.3
Date: Sun, 5 Sep 2021 16:13:17 +0200	[thread overview]
Message-ID: <20210905161317.064e7d03@windsurf> (raw)
In-Reply-To: <20210903153746.19425-1-david.gouarin@thalesgroup.com>

On Fri,  3 Sep 2021 17:37:45 +0200
David GOUARIN <dgouarin@gmail.com> wrote:

> -sha256  ef4822d2fdafd2be8e0cabc3ec3c806ae29b8268e932c5e9a4cd5585f37f9f77  talloc-2.3.1.tar.gz
> -sha256  15c2767545d1e43dc35832736253bde5be956f8ffec0474a6d0f70349b646ed3  talloc.h
> -sha256  8742f2dad3aaf885c7b4b699c20bfa0e9edeab380689f91a88aa90af03e6947b  pytalloc.h
> +sha256  6be95b2368bd0af1c4cd7a88146eb6ceea18e46c3ffc9330bf6262b40d1d8aaa  talloc-2.3.3.tar.gz
> +sha256  f8340c449dd64a55c6605b02fcad2aec6f473612ac6026739a22995380a8043c  talloc.h
> +sha256  cca17b31b2f00d7a737764b70e2be3a32f3b047ac8535c3b53759eb2946e5053  pytalloc.h

You did not explain the changes of the hashes for the license files.
And in fact, it seems like there are some important changes in
pytalloc.h:

--- output/build/libtalloc-2.3.1/pytalloc.h     2019-12-16 10:14:22.000000000 +0100
+++ output/build/libtalloc-2.3.3/pytalloc.h     2021-03-24 12:48:55.000000000 +0100
@@ -3,18 +3,22 @@
    Samba utility functions
    Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2008
    
-   This program is free software; you can redistribute it and/or modify
-   it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 3 of the License, or
-   (at your option) any later version.
-   
-   This program is distributed in the hope that it will be useful,
+     ** NOTE! The following LGPL license applies to the talloc
+     ** library. This does NOT imply that all of Samba is released
+     ** under the LGPL
+
+   This library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 3 of the License, or (at your option) any later version.
+
+   This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-   GNU General Public License for more details.
-   
-   You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with this library; if not, see <http://www.gnu.org/licenses/>.

So it seems like this part was under GPL-3.0+ before, and it is now
under LGPL-3.0+. Could you look into this, and assess whether
LIBTALLOC_LICENSE needs to be changed in libtalloc.mk ?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
