Re: [Buildroot] [PATCH 1/8] boot/grub2: add support to build multiple Grub2 configurations in the same build

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, Köry, All,

On 2021-09-18 10:50 +0200, Thomas Petazzoni spake thusly:
> On Fri, 17 Sep 2021 23:24:29 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > What you forgot to state in bold fat characters here, is that we can no
> > longer use autotools-package as a consequence of this multi-build, and
> > that we have to resort to generic-pacakge and a partial duplication of
> > the autotools-infra.
[--SNIP--]
> > If I understand correctly, we are in a similar situation with grub2, and
> > there are only ever at most two "platforms" we can build, and it does
> > not look like it will ever change:
[--SNIP--]
> >     x86_64:
> >         BR2_TARGET_GRUB2_I386_EFI
> >         BR2_TARGET_GRUB2_X86_64_EFI
> On x86-64, we can have:
> 	BR2_TARGET_GRUB2_I386_PC
> 	BR2_TARGET_GRUB2_I386_EFI
> 	BR2_TARGET_GRUB2_X86_64_EFI
> 
> to cover legacy BIOS platforms (32-bit), 32-bit EFI BIOS and 64-bit EFI
> BIOS. Dans this is precisely the use-case we are in fact interested in.
> 
> So that means we would need 3 Grub packages, which is the reason why it
> felt much more reasonable to just extend the grub2 package itself.

Arg, I indeed missed the BR2_TARGET_GRUB2_I386_PC for x86-64, which
indeed basically invalidates the two-package solution, and the
three-package alternative is not a viable solution either...

[--SNIP--]
> > > -$(eval $(autotools-package))
> > > +$(eval $(generic-package))  
> > This is my main problem: we're mostly duplicating bits and pieces of the
> > autotolls-package infra, which means we *will* fall behind very quickly
> > when we have to update said infra, and those changes will not percolate
> > to this grub2 package.
> That is true, but on the other hand, grub2 is not the typical
> user-space autotools package either.
[--SNIP--]
> So even though we do use autotools-package, it's not like we don't
> already have to play quite a few tricks to get it to do the right thing
> with the weirdness of grub2.

That's true.

Köry: when you respin, in addition to the other points, can you extend
the commit log with a summary of the explanations from Thomas, on why a
multi-package solution like barebox is not viable, and that grub2 is
already pretty special anyway, please?

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot