From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64E6C433EF for ; Tue, 21 Sep 2021 14:16:33 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55A2960EDF for ; Tue, 21 Sep 2021 14:16:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55A2960EDF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0401740696; Tue, 21 Sep 2021 14:16:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gYJlT3b_mnnE; Tue, 21 Sep 2021 14:16:32 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 5F26E40694; Tue, 21 Sep 2021 14:16:31 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id E027A1BF2B6 for ; Tue, 21 Sep 2021 14:16:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CFA3F60BB3 for ; Tue, 21 Sep 2021 14:16:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XeX_DLayrQXQ for ; Tue, 21 Sep 2021 14:16:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [217.70.178.232]) by smtp3.osuosl.org (Postfix) with ESMTPS id A1478606A5 for ; Tue, 21 Sep 2021 14:16:28 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A7B05200008; Tue, 21 Sep 2021 14:16:25 +0000 (UTC) Date: Tue, 21 Sep 2021 16:16:24 +0200 From: Thomas Petazzoni To: Kamel Bouhara Message-ID: <20210921161624.7d4ec53f@windsurf> In-Reply-To: <20210921130326.3462783-8-kamel.bouhara@bootlin.com> References: <20210921130326.3462783-1-kamel.bouhara@bootlin.com> <20210921130326.3462783-8-kamel.bouhara@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 7/8] package/kmscube: use libgbm virtual package X-BeenThere: buildroot@lists.buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@lists.buildroot.org Sender: "buildroot" Hello Kamel, On Tue, 21 Sep 2021 15:03:24 +0200 Kamel Bouhara wrote: > From: Thomas Petazzoni > > kmscube requires a libgbm implementation, which until now, only Mesa3D > was providing, so kmscube had a direct dependency on Mesa3D. > > However, now that we have a proper libgbm virtual package, so this > commit converts the kmscube package to use the libegl, libgbm and > libgles virtual packages. > > Signed-off-by: Thomas Petazzoni > Signed-off-by: Kamel Bouhara > [ Kamel : add dependency on recent libgbm ] > --- > package/kmscube/Config.in | 18 ++++++++++++++---- > package/kmscube/kmscube.mk | 3 ++- > 2 files changed, 16 insertions(+), 5 deletions(-) > > diff --git a/package/kmscube/Config.in b/package/kmscube/Config.in > index b6ad305bfb..d97b0f962e 100644 > --- a/package/kmscube/Config.in > +++ b/package/kmscube/Config.in > @@ -1,9 +1,19 @@ > config BR2_PACKAGE_KMSCUBE > bool "kmscube" > - # requires libgbm from mesa3d > - depends on BR2_PACKAGE_MESA3D_OPENGL_EGL > - depends on BR2_PACKAGE_MESA3D_OPENGL_ES > + depends on BR2_PACKAGE_HAS_LIBEGL > + depends on BR2_PACKAGE_HAS_LIBGBM > + depends on BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_NAME_DESC This does not exist in your PATCH 2/8: +config BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_MODIFIER_PLANE_COUNT +config BR2_PACKAGE_LIBGBM_HAS_FEATURE_DMA_BUF Did you test this patch ? > +comment "kmscube needs a toolchain w/ threads support" > + depends on BR2_PACKAGE_HAS_LIBEGL > + depends on BR2_PACKAGE_HAS_LIBGBM > + depends on BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_NAME_DESC > + depends on BR2_PACKAGE_HAS_LIBGLES > + depends on !BR2_TOOLCHAIN_HAS_THREADS This should be: comment "kmscube needs EGL, GBM and OpenGL ES, and a toolchain w/ thread support" > diff --git a/package/kmscube/kmscube.mk b/package/kmscube/kmscube.mk > index 7b458376dc..26c82d2688 100644 > --- a/package/kmscube/kmscube.mk > +++ b/package/kmscube/kmscube.mk > @@ -8,6 +8,7 @@ KMSCUBE_VERSION = 4660a7dca6512b6e658759d00cff7d4ad2a2059d > KMSCUBE_SITE = https://gitlab.freedesktop.org/mesa/kmscube/-/archive/$(KMSCUBE_VERSION) > KMSCUBE_LICENSE = MIT > KMSCUBE_LICENSE_FILES = COPYING > -KMSCUBE_DEPENDENCIES = host-pkgconf mesa3d libdrm > +KMSCUBE_DEPENDENCIES = host-pkgconf libgles libegl libgbm libdrm > +KMSCUBE_AUTORECONF = YES Why is autoreconf being added here ? On a meson-package, this doesn't make much sense. Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@lists.buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot