From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2951AC433F5 for ; Sat, 25 Sep 2021 06:49:30 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8FCA61260 for ; Sat, 25 Sep 2021 06:49:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B8FCA61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6496982662; Sat, 25 Sep 2021 06:49:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVp8i8m7PsAd; Sat, 25 Sep 2021 06:49:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 5BA388266C; Sat, 25 Sep 2021 06:49:26 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4CDD01BF30F for ; Sat, 25 Sep 2021 06:49:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 497188266C for ; Sat, 25 Sep 2021 06:49:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id szRtR3lHYzdj for ; Sat, 25 Sep 2021 06:49:24 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from smtp6-g21.free.fr (smtp6-g21.free.fr [IPv6:2a01:e0c:1:1599::15]) by smtp1.osuosl.org (Postfix) with ESMTPS id 1BAD082662 for ; Sat, 25 Sep 2021 06:49:24 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:e5cb:5ead:8e76:4901]) (Authenticated sender: yann.morin.1998@free.fr) by smtp6-g21.free.fr (Postfix) with ESMTPSA id 33830780313; Sat, 25 Sep 2021 08:49:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1632552562; bh=WnFJEQ+i33m3q6CfuJ53gV+pxxcwLxp+Knh7du/9bX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hjH5GFbRrz1APYwtPl0N8DASZuFruvqjNFAw1QDuAstdaMICWpEmu1dIaZlTHbtBZ HCdDCgjeOdXZn/bHdLf2AARLNj4makhBeJFjYv88/LeYIc6elmTsRd0a+keeGkI4YJ z92b5L3VsAgU5mgW8xzClSGymv5SS0DjkE/3Dy4yjbY7zYRP5sJZk+xJ7Diu54M5XC m8RUsgS4UIiNXl5+st/aPLl4Xa++jojjsL6rx7VQFwj/tNK4M5XPuML4WV2gCVNMFC KjrNagO23p5K2VMy17vjOSiguWtoL4VBkzzE37exCxNZJChglZaAaf0U/tiL6msKG7 /Ce4M4LXyN/tg== Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sat, 25 Sep 2021 08:49:15 +0200 Date: Sat, 25 Sep 2021 08:49:15 +0200 From: "Yann E. MORIN" To: Fabrice Fontaine Message-ID: <20210925064915.GK3176@scaer> References: <20210924213946.2888625-1-fontaine.fabrice@gmail.com> <20210925063209.GJ3176@scaer> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210925063209.GJ3176@scaer> User-Agent: Mutt/1.5.22 (2013-10-16) Subject: Re: [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org, Jared Bents Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Fabrice, All, On 2021-09-25 08:32 +0200, Yann E. MORIN spake thusly: > On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly: > > Make a standard install (i.e. with pvcreate) for host as it is needed > > for libvirt > > > > Signed-off-by: Fabrice Fontaine > > --- > > package/lvm2/lvm2.mk | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk > > index 3a94aebfd4..d918b5f5b6 100644 > > --- a/package/lvm2/lvm2.mk > > +++ b/package/lvm2/lvm2.mk > > @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \ > > --disable-fsadm \ > > --disable-readline \ > > --disable-selinux > > -HOST_LVM2_MAKE_OPTS = device-mapper > > -HOST_LVM2_INSTALL_OPTS = install_device-mapper > > +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install > > DESTDIR must not be used for host variants. > > Indeed, they are already configured with --prefix=$(HOST_DIR) : > https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223 > > And DESTDIR is for out-of-tree installation, but for host packages we do > not install out-of-tree as their prefix is already correct. > https://www.gnu.org/software/automake/manual/automake.html#DESTDIR > > If the install fails because of things installed in /etc and such, then > appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified > instead. Or maybe we only need 'make install-exec' ? lvm2 does not support install-exec... :-/ Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot