Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Asaf Kahlon <asafka7@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3
Date: Sat, 25 Sep 2021 18:33:08 +0200	[thread overview]
Message-ID: <20210925163308.GQ3176@scaer> (raw)
In-Reply-To: <20210924170014.111889-1-asafka7@gmail.com>

Asaf, All,

On 2021-09-24 20:00 +0300, Asaf Kahlon spake thusly:
> python-attrs contains a file with API for python 3.6+.
> Although we can make a "tweak" and remove this specific file
> for python2, we prefer to make this package available only for
> python3, because the day this package (and many others) will drop
> support for python2 is probably very close.
> 
> In addition, update python-attrs recursive dependencies to
> depend on python3 too (python-automat is the only one left).
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/aa6/aa6889bc254eaa93adb4fc1a71bcee9f2f23cb33/
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  package/python-attrs/Config.in   | 1 +
>  package/python-automat/Config.in | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/package/python-attrs/Config.in b/package/python-attrs/Config.in
> index fb0ab248fa..b658d20ec9 100644
> --- a/package/python-attrs/Config.in
> +++ b/package/python-attrs/Config.in
> @@ -1,4 +1,5 @@
>  config BR2_PACKAGE_PYTHON_ATTRS
> +	depends on BR2_PACKAGE_PYTHON3

    $ make check-package
    package/python-attrs/Config.in:3: attributes order: type, default,
    depends on, select, help (http://nightly.buildroot.org/#_config_files)

Applied to master with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  	bool "python-attrs"
>  	help
>  	  attrs is the Python package that will bring back the joy of
> diff --git a/package/python-automat/Config.in b/package/python-automat/Config.in
> index ee02d22b5b..9d22276c2c 100644
> --- a/package/python-automat/Config.in
> +++ b/package/python-automat/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_AUTOMAT
>  	bool "python-automat"
> +	depends on BR2_PACKAGE_PYTHON3 # python-attrs
>  	select BR2_PACKAGE_PYTHON_ATTRS # runtime
>  	select BR2_PACKAGE_PYTHON_SIX # runtime
>  	help
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-09-25 16:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 17:00 [Buildroot] [PATCH 1/1] package/python-attrs: depends on python3 Asaf Kahlon
2021-09-25 16:33 ` Yann E. MORIN [this message]
2021-09-26 12:55   ` Romain Naour
2021-09-26 13:11     ` Asaf Kahlon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210925163308.GQ3176@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox