From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Antoine Tenart <atenart@kernel.org>
Cc: "José Pekkarinen" <jose.pekkarinen@unikie.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/refpolicy: make sure xmllint is used
Date: Mon, 27 Sep 2021 18:35:28 +0200 [thread overview]
Message-ID: <20210927163528.GA1357968@scaer> (raw)
In-Reply-To: <20210923092136.141553-1-atenart@kernel.org>
Antoine, All,
On 2021-09-23 11:21 +0200, Antoine Tenart spake thusly:
> When parsing and adding modules the refpolicy build system checks their
> validity using xmllint. By default the host system version is used and
> if not found an error is displayed but the build is not stopped. This
> leads to interesting issues where modules are not added correctly to
> modules.conf[1] (other possible issues are likely).
>
> Fix this by adding a dependency on host-libxml2 and explicitly use the
> xmllint binary built by Buildroot.
>
> [1] https://lore.kernel.org/buildroot/20210830114531.2285178-1-jose.pekkarinen@unikie.com/
>
> Tested-by: José Pekkarinen <jose.pekkarinen@unikie.com>
> Signed-off-by: Antoine Tenart <atenart@kernel.org>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/refpolicy/refpolicy.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/refpolicy/refpolicy.mk b/package/refpolicy/refpolicy.mk
> index eb345d0f98c9..975c3b584c42 100644
> --- a/package/refpolicy/refpolicy.mk
> +++ b/package/refpolicy/refpolicy.mk
> @@ -14,7 +14,8 @@ REFPOLICY_DEPENDENCIES = \
> host-policycoreutils \
> host-python3 \
> host-setools \
> - host-gawk
> + host-gawk \
> + host-libxml2
>
> ifeq ($(BR2_PACKAGE_REFPOLICY_CUSTOM_GIT),y)
> REFPOLICY_VERSION = $(call qstrip,$(BR2_PACKAGE_REFPOLICY_CUSTOM_REPO_VERSION))
> @@ -30,6 +31,7 @@ endif
> # Cannot use multiple threads to build the reference policy
> REFPOLICY_MAKE = \
> PYTHON=$(HOST_DIR)/usr/bin/python3 \
> + XMLLINT=$(LIBXML2_HOST_BINARY) \
> TEST_TOOLCHAIN=$(HOST_DIR) \
> $(TARGET_MAKE_ENV) \
> $(MAKE1)
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-27 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 9:21 [Buildroot] [PATCH] package/refpolicy: make sure xmllint is used Antoine Tenart
2021-09-27 16:35 ` Yann E. MORIN [this message]
2021-10-06 14:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927163528.GA1357968@scaer \
--to=yann.morin.1998@free.fr \
--cc=atenart@kernel.org \
--cc=buildroot@buildroot.org \
--cc=jose.pekkarinen@unikie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox