Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Edgar Bonet <bonet@grenoble.cnrs.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/testing: fix python_flask_expect_python
Date: Wed, 6 Oct 2021 22:44:13 +0200	[thread overview]
Message-ID: <20211006224413.31235052@windsurf> (raw)
In-Reply-To: <20211006203823.2740442-1-yann.morin.1998@free.fr>

On Wed,  6 Oct 2021 22:38:23 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Commit e6ee07f41a2b (package/python-flask-expects-json: new package)
> added a non-functional test case that, as noticed by Edgar, fails with:
> 
>     AssertionError: '%{http_code}' != '200'
> 
> That's because the % sign is self-escaped, à-la C, in the first part
> of the command, probably to avoid its being %-formatted. But only the
> second part of the command is %-formatted, so we do not need to
> self-escape % in the first part.

Gaah, seemingly innocent-looking last minute (untested) refactoring is
ALWAYS wrong. Sorry about this and thanks for fixing my crap.

> Additionally, since eb3ee3078a76 (support/testing/infra/emulator.py:
> prevent the commands from wrapping), we no longer need to play tricks
> with commands that are too long to fit on the first line of the shell
> prompt.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Edgar Bonet <bonet@grenoble.cnrs.fr>

Looks good:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-06 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06 20:38 [Buildroot] [PATCH] support/testing: fix python_flask_expect_python Yann E. MORIN
2021-10-06 20:44 ` Thomas Petazzoni [this message]
2021-10-12 20:54 ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211006224413.31235052@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=bonet@grenoble.cnrs.fr \
    --cc=buildroot@buildroot.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox