Re: [Buildroot] [PATCH 1/1] package/transmission: fix build with autoconf >= 2.71

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/transmission: fix build with autoconf >= 2.71
Date: Sat, 9 Oct 2021 21:46:59 +0200	[thread overview]
Message-ID: <20211009214659.30a58c90@windsurf> (raw)
In-Reply-To: <20211009170242.486738-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Sat,  9 Oct 2021 19:02:42 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since bump of autoconf to version
> 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da:
> 
> ERROR: 'IT_PROG_INTLTOOL' must appear in configure.ac for intltool to work.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e8bea26f6b12adf16335b24836a7c5c31911af6a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...ac-fix-autoreconf-with-autoconf-2.71.patch | 39 +++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 package/transmission/0003-configure.ac-fix-autoreconf-with-autoconf-2.71.patch
> 
> diff --git a/package/transmission/0003-configure.ac-fix-autoreconf-with-autoconf-2.71.patch b/package/transmission/0003-configure.ac-fix-autoreconf-with-autoconf-2.71.patch
> new file mode 100644
> index 0000000000..9522f611ba
> --- /dev/null
> +++ b/package/transmission/0003-configure.ac-fix-autoreconf-with-autoconf-2.71.patch
> @@ -0,0 +1,39 @@
> +From 857ac91a03a096601f62b358fc61355d4cc25b9b Mon Sep 17 00:00:00 2001
> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +Date: Sat, 9 Oct 2021 18:51:13 +0200
> +Subject: [PATCH] configure.ac: fix autoreconf with autoconf >= 2.71
> +
> +Remove the whitespace before IT_PROG_INTLTOOL as suggested in
> +https://www.mail-archive.com/bug-autoconf@gnu.org/msg04851.html
> +to avoid the following build failure with autoconf >= 2.71:
> +
> +ERROR: 'IT_PROG_INTLTOOL' must appear in configure.ac for intltool to work.
> +
> +Fixes:
> + - http://autobuild.buildroot.org/results/e8bea26f6b12adf16335b24836a7c5c31911af6a
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +[Upstream status: not upstreamable as upstream swicthed to cmake (
> +https://github.com/transmission/transmission/issues/1573)]

I am rather confused, because I don't see any changes between autoconf
2.70 and 2.71 that seem to explain this, and the message "ERROR:
'IT_PROG_INTLTOOL' must appear in configure.ac for intltool to work"
comes from intltoolize.in, which is in host-intltool, which has not
been updated for at least 2 years in Buildroot.

> +@@ -555,9 +555,7 @@ dnl it should be safe to re-edit 0.40 back down to 0.23
> + use_nls=no
> + if test "x$enable_nls" = "xyes" ; then
> +     use_nls=yes
> +-    m4_ifdef([IT_PROG_INTLTOOL],
> +-             [IT_PROG_INTLTOOL([0.35.0],[no-xml])],
> +-             [AC_MSG_ERROR("--enable-nls requires intltool to be installed.")])
> ++IT_PROG_INTLTOOL([0.35.0],[no-xml])
> +     AC_CHECK_HEADERS([libintl.h])
> +     GETTEXT_PACKAGE=transmission-gtk
> +     AC_SUBST(GETTEXT_PACKAGE)

So you're getting rid of the IT_PROG_INTLTOOL m4_ifdef test ? I guess
it's OK in the context of Buildroot, because transmission
unconditionally depends on host-intltool, so IT_PROG_INTLTOOL will
always be available.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot