From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67162C433F5 for ; Sat, 9 Oct 2021 20:09:16 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08C7460F55 for ; Sat, 9 Oct 2021 20:09:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08C7460F55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id CDCB640255; Sat, 9 Oct 2021 20:09:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YIr6QLrf7wRP; Sat, 9 Oct 2021 20:09:14 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id E084340018; Sat, 9 Oct 2021 20:09:13 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 4AFCC1BF3C6 for ; Sat, 9 Oct 2021 20:09:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4805182F41 for ; Sat, 9 Oct 2021 20:09:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gft8J7lTGnOz for ; Sat, 9 Oct 2021 20:09:11 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by smtp1.osuosl.org (Postfix) with ESMTPS id 2139182F3D for ; Sat, 9 Oct 2021 20:09:10 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 53B11240002; Sat, 9 Oct 2021 20:09:09 +0000 (UTC) Date: Sat, 9 Oct 2021 22:09:08 +0200 From: Thomas Petazzoni To: Fabrice Fontaine Message-ID: <20211009220908.39301a19@windsurf> In-Reply-To: <20211009075004.370428-1-fontaine.fabrice@gmail.com> References: <20211009075004.370428-1-fontaine.fabrice@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/1] package/ltrace: fix autoreconf with autoconf >= 2.70 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Sat, 9 Oct 2021 09:50:04 +0200 Fabrice Fontaine wrote: > Fix the following build failure raised since bump of autoconf to version > 2.71 in commit ecd54b65c1f998a7ccd91f7c523e4ff38c4781da: > > autoreconf: error: cannot create config/autoconf: No such file or directory > > Fixes: > - http://autobuild.buildroot.org/results/433599039d6e1ee301465f9867e169c121a0646f > > Signed-off-by: Fabrice Fontaine > --- > ...ac-fix-autoreconf-with-autoconf-2.70.patch | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 package/ltrace/0003-configure.ac-fix-autoreconf-with-autoconf-2.70.patch I've extended the explanation to indicate why removing the AC_CONFIG_AUX_DIR invocation is OK: it's because there is no config/autoconf directory. I think your commit log should try to explain why a change is OK, not just "we're removing stuff to fix a build failure". Applied to master with the extended commit log. Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot