Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Michael Rommel <rommel@layer-7.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/knock: bump to version 0.8
Date: Sun, 10 Oct 2021 22:55:30 +0200	[thread overview]
Message-ID: <20211010205530.GR2081069@scaer> (raw)
In-Reply-To: <20211010194937.1419893-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-10-10 21:49 +0200, Fabrice Fontaine spake thusly:
> Use official tarball and so drop autoreconf

This is not very nice, in fact, because that tarball is a complete git
working copy... :-/

Even though this is reproducible (it's a tarball. after all, I do not
like it much that we carry a complete git tree.

I would prefer that we do explicitly use a git tree, or that we use the
github download helper instead. We just lose the upstream-provided
sha256sum of the archive...

Thoughts?

> https://github.com/jvinet/knock/blob/v0.8/ChangeLog

Since we had a commit hash, we don't really know where we're updating
from. That commit was from almost 6 years ago, and was already marked
as a 0.7.8 version. Meh...

Regards,
Yann E. MORIN.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/knock/knock.hash | 4 +++-
>  package/knock/knock.mk   | 5 ++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/knock/knock.hash b/package/knock/knock.hash
> index 0b9a0918fc..3dc971b4a1 100644
> --- a/package/knock/knock.hash
> +++ b/package/knock/knock.hash
> @@ -1,3 +1,5 @@
> +# Hash from: https://zeroflux.org/projects/knock
> +sha256  698d8c965624ea2ecb1e3df4524ed05afe387f6d20ded1e8a231209ad48169c7  knock-0.8.tar.gz
> +
>  # locally computed hash
> -sha256  940a8de61b4b3530560805c3b9310a077c28c99173c2ccb07ff96720b0e93c58  knock-258a27e5a47809f97c2b9f2751a88c2f94aae891.tar.gz
>  sha256  d747e19206e41702e40822dd91d37cbf40edd86f364ea416d667a0e3013f7189  COPYING
> diff --git a/package/knock/knock.mk b/package/knock/knock.mk
> index 55f5bfdf36..02811540bf 100644
> --- a/package/knock/knock.mk
> +++ b/package/knock/knock.mk
> @@ -4,9 +4,8 @@
>  #
>  ################################################################################
>  
> -KNOCK_VERSION = 258a27e5a47809f97c2b9f2751a88c2f94aae891
> -KNOCK_SITE = $(call github,jvinet,knock,$(KNOCK_VERSION))
> -KNOCK_AUTORECONF = YES
> +KNOCK_VERSION = 0.8
> +KNOCK_SITE = http://www.zeroflux.org/proj/knock/files
>  KNOCK_LICENSE = GPL-2.0+
>  KNOCK_LICENSE_FILES = COPYING
>  KNOCK_DEPENDENCIES = libpcap
> -- 
> 2.33.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2021-10-10 20:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 19:49 [Buildroot] [PATCH 1/2] package/knock: bump to version 0.8 Fabrice Fontaine
2021-10-10 19:49 ` [Buildroot] [PATCH 2/2] package/knock: add knockd option Fabrice Fontaine
2021-10-10 20:55 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211010205530.GR2081069@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=rommel@layer-7.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox