From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Gleb Mazovetskiy <glex.spb@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>,
yann.morin.1998@free.fr, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 2/2] package: add smpq
Date: Sun, 17 Oct 2021 11:37:17 +0200 [thread overview]
Message-ID: <20211017113717.3f642315@windsurf> (raw)
In-Reply-To: <20211011212125.402086-3-glex.spb@gmail.com>
Hello Gleb,
On Mon, 11 Oct 2021 22:21:25 +0100
Gleb Mazovetskiy <glex.spb@gmail.com> wrote:
> smpq is a utility for manipulating Blizzard MPQ archives.
>
> smpq is a build-time dependency of several source ports /
> reimplementations of Blizzard games, such as DevilutionX.
>
> Signed-off-by: Gleb Mazovetskiy <glex.spb@gmail.com>
Thanks for this contribution. Could you clarify practical speaking in
which context this library is useful?
> --- /dev/null
> +++ b/package/smpq/smpq.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# smpq
> +#
> +################################################################################
> +
> +SMPQ_VERSION = 1.6
> +SMPQ_SOURCE = smpq_$(SMPQ_VERSION).orig.tar.gz
> +SMPQ_SITE = https://launchpad.net/smpq/trunk/$(SMPQ_VERSION)/+download
> +SMPQ_LICENSE = GPL-3.0+
> +SMPQ_LICENSE_FILES = LICENSE
> +SMPQ_DEPENDENCIES = stormlib
> +HOST_SMPQ_DEPENDENCIES = host-stormlib
> +SMPQ_CONF_OPTS += -DWITH_KDE=OFF
> +HOST_SMPQ_CONF_OPTS += -DWITH_KDE=OFF
> +SMPQ_INSTALL_STAGING = YES
> +
> +$(eval $(cmake-package))
> +$(eval $(host-cmake-package))
Why do you need a host variant of this package? It isn't used by
anything else. Could you clarify this?
Note: for both of your package submissions, the commit title should be
"package/<foo>: new package". And also, in each patch adding the
packages, you need to add yourself in the DEVELOPERS file for this
package.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-17 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 17:09 [Buildroot] [PATCH] package: add smpq and stormlib Gleb Mazovetskiy
2021-10-10 21:07 ` Yann E. MORIN
2021-10-11 21:00 ` [Buildroot] [PATCH v2 1/1] " Gleb Mazovetskiy
2021-10-11 21:02 ` [Buildroot] [PATCH v3 " Gleb Mazovetskiy
2021-10-11 21:21 ` [Buildroot] [PATCH v4 0/2] package: add smpq and StormLib Gleb Mazovetskiy
2021-10-11 21:21 ` [Buildroot] [PATCH v4 1/2] package: add stormlib Gleb Mazovetskiy
2021-10-11 21:21 ` [Buildroot] [PATCH v4 2/2] package: add smpq Gleb Mazovetskiy
2021-10-17 9:37 ` Thomas Petazzoni [this message]
2021-10-17 14:05 ` Gleb Mazovetskiy
2021-10-20 20:34 ` Thomas Petazzoni
2021-10-21 0:08 ` Gleb Mazovetskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017113717.3f642315@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=glex.spb@gmail.com \
--cc=s.martin49@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox