Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Luca Ceresoli <luca@lucaceresoli.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] configs/olimex_a20_olinuxino: fix mali not working because Linux version >= 4.20
Date: Mon, 18 Oct 2021 21:45:35 +0200	[thread overview]
Message-ID: <20211018214535.5743fd67@windsurf> (raw)
In-Reply-To: <20211015081514.2472764-1-giulio.benetti@benettiengineering.com>

On Fri, 15 Oct 2021 10:15:14 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Since on olinuxino_lime/lime2 we have a Linux version >= 4.20 we need to
> pass drm_kms_helper.drm_leak_fbdev_smem=1 to kernel command-line that
> really enables DRM_FBDEV_LEAK_PHYS_SMEM. CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
> only adds the code for this, but drm_leak_fbdev_smem is 0 by default, so we
> need to override it with 1. Same goes for drm_fbdev_overalloc that
> must be at least 200 for having a double buffer that is required by
> Mali. This fixes both olimex_a20_olinuxino_lime and lime2 that use
> extlinux.conf.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

I appreciate the idea, but I'm not sure if we want this. Indeed, the
A20 Olinuxino defconfigs are meant to be minimal, and there's nothing
that forces anyone to use the proprietary Mali driver+blob, they can
also use mesa3d instead, which might have different requirements.

So I'm rather keen on enabling your patch on
sunxi-mali-mainline-driver/Config.in, but not this one I'm afraid.

Of course, if others disagree, I can change my mind :)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-10-18 19:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 21:36 [Buildroot] [PATCH] configs/olimex_a20_olinuxino: fix mali not working because Linux version >= 4.20 Giulio Benetti
2021-10-14 22:11 ` Giulio Benetti
2021-10-15  8:15   ` [Buildroot] [PATCH v2] " Giulio Benetti
2021-10-18 19:45     ` Thomas Petazzoni [this message]
2021-10-18 19:59       ` Giulio Benetti
2021-10-18 21:40         ` Thomas Petazzoni
2022-01-08 16:29           ` Giulio Benetti
2022-01-08 20:57 ` [Buildroot] [PATCH] " Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211018214535.5743fd67@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=luca@lucaceresoli.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox