From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Adam Duskett <aduskett@gmail.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build
Date: Mon, 18 Oct 2021 21:52:44 +0200 [thread overview]
Message-ID: <20211018215244.6751d246@windsurf> (raw)
In-Reply-To: <20211017200558.1409403-1-fontaine.fabrice@gmail.com>
On Sun, 17 Oct 2021 22:05:58 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following build failure raised since commit
> 21a56f9edbca8dd8b19567be6be2b32e44ebb860 which wrongly removed
> the select on BR2_PACKAGE_BZIP2 from BR2_PACKAGE_PYTHON3_BZIP2:
>
> Makefile:587: *** bzip2 is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop.
>
> Fixes:
> - http://autobuild.buildroot.org/results/041a2f9c536fce1a1acf6da0464855e4f1e1604f
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/python3/Config.in | 1 +
> 1 file changed, 1 insertion(+)
Indeed, there's been a misunderstanding. Arnout asked to drop the
"select BR2_PACKAGE_HOST_BZIP2" from package/python3/Config.in.host,
but Adam removed the "select BR2_PACKAGE_BZIP2" from
package/python3/Config.in instead, and Arnout didn't spot the mistake
when applying.
Anyway, I've applied your patch, and did another to drop the bogus
select BR2_PACKAGE_HOST_BZIP2. Thanks for fixing this!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-10-18 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 20:05 [Buildroot] [PATCH 1/1] package/python3: fix bzip2 build Fabrice Fontaine
2021-10-18 19:52 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018215244.6751d246@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=aduskett@gmail.com \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox