From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Romain Naour <romain.naour@gmail.com>,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/{mesa3d, mesa3d-headers}: bump version to 21.2.4
Date: Mon, 18 Oct 2021 22:00:02 +0200 [thread overview]
Message-ID: <20211018220002.4301fda1@windsurf> (raw)
In-Reply-To: <20211015162612.1662548-1-bernd.kuhls@t-online.de>
Hello Bernd,
On Fri, 15 Oct 2021 18:26:12 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> diff --git a/package/mesa3d/0006-fix-cpp-detection.patch b/package/mesa3d/0006-fix-cpp-detection.patch
> new file mode 100644
> index 0000000000..7e78eef1dd
> --- /dev/null
> +++ b/package/mesa3d/0006-fix-cpp-detection.patch
> @@ -0,0 +1,23 @@
> +Fix c++ detection
> +
> +Fixes build error:
> +
> +../src/egl/main/egldisplay.c: In function ‘_eglGetNativePlatformFromEnv’:
> +../src/egl/main/egldisplay.c:93:4: error: implicit declaration of function
> + ‘static_assert’ [-Werror=implicit-function-declaration]
> + 93 | static_assert(ARRAY_SIZE(egl_platforms) == _EGL_NUM_PLATFORMS,
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Thanks a lot for this update, but in 2021, we really want patches
against packages that are developed with Git to be generated with "git
format-patch", and also it should have an upstream status (submitted
upstream, as mesa3d is active). It also needs a decent explanation
other than just "remove code to fix build".
Could you have a look into this ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-18 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:26 [Buildroot] [PATCH v2 1/1] package/{mesa3d, mesa3d-headers}: bump version to 21.2.4 Bernd Kuhls
2021-10-18 20:00 ` Thomas Petazzoni [this message]
[not found] ` <20211018220002.4301fda1__48889.7956720152$1634587229$gmane$org@windsurf>
2021-10-28 20:12 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018220002.4301fda1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox