From: Peter Seiderer <ps.report@gmx.net>
To: Grzegorz Blach <grzegorz@blach.pl>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Martin Bark <martin@barkynet.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation
Date: Wed, 20 Oct 2021 18:30:58 +0200 [thread overview]
Message-ID: <20211020183058.13830eea@gmx.net> (raw)
In-Reply-To: <20211020120327.5768-1-grzegorz@blach.pl>
Hello Grzegorz,
On Wed, 20 Oct 2021 14:03:24 +0200, Grzegorz Blach <grzegorz@blach.pl> wrote:
> Variable PACKAGE_RPI_FIRMWARE_CONFIG_FILE is always undefined,
> so RPI_FIRMWARE_CONFIG_FILE should be used instead.
>
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> ---
> package/rpi-firmware/rpi-firmware.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 8a6a435f63..0929d6af1e 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -28,9 +28,9 @@ define RPI_FIRMWARE_INSTALL_BIN
> endef
>
> RPI_FIRMWARE_CONFIG_FILE = $(call qstrip,$(BR2_PACKAGE_RPI_FIRMWARE_CONFIG_FILE))
> -ifneq ($(PACKAGE_RPI_FIRMWARE_CONFIG_FILE),)
> +ifneq ($(RPI_FIRMWARE_CONFIG_FILE),)
> define RPI_FIRMWARE_INSTALL_CONFIG
> - $(INSTALL) -D -m 0644 $(PACKAGE_RPI_FIRMWARE_CONFIG_FILE) \
> + $(INSTALL) -D -m 0644 $(RPI_FIRMWARE_CONFIG_FILE) \
> $(BINARIES_DIR)/rpi-firmware/config.txt
> endef
> endif
Thanks for spotting (and fixing) this...
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-20 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 12:03 [Buildroot] [PATCH] package/rpi-firmware: Fix config.txt installation Grzegorz Blach
2021-10-20 16:30 ` Peter Seiderer [this message]
2021-10-20 16:39 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020183058.13830eea@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=grzegorz@blach.pl \
--cc=mahyar.koshkouei@gmail.com \
--cc=martin@barkynet.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox