From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB61C433F5 for ; Thu, 21 Oct 2021 16:09:09 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FA96611CB for ; Thu, 21 Oct 2021 16:09:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FA96611CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6DF2C606E5; Thu, 21 Oct 2021 16:09:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rynCjKG1eaCF; Thu, 21 Oct 2021 16:09:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C273D6060E; Thu, 21 Oct 2021 16:09:06 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 094E31BF20B for ; Thu, 21 Oct 2021 16:09:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id EA0BF4072A for ; Thu, 21 Oct 2021 16:09:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uPDUEIwSauAf for ; Thu, 21 Oct 2021 16:09:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by smtp2.osuosl.org (Postfix) with ESMTPS id 9582840017 for ; Thu, 21 Oct 2021 16:09:03 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id BB1FA240009; Thu, 21 Oct 2021 16:08:59 +0000 (UTC) Date: Thu, 21 Oct 2021 18:08:59 +0200 From: Thomas Petazzoni To: Kory Maincent Message-ID: <20211021180859.356b1a97@windsurf> In-Reply-To: <20211021160612.475456-1-kory.maincent@bootlin.com> References: <20211021160612.475456-1-kory.maincent@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] boot/grub2/grub2.mk: Fix the installation of target tools X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yann.morin.1998@free.fr, aduskett@gmail.com, buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Thu, 21 Oct 2021 18:06:12 +0200 Kory Maincent wrote: > The tools was not installed anymore since we move from autotools to > generic-package. This patch fixes their installation. > > We have decided to implement the install tool process by running the "make > install" command for each tuples. This allows to have all different > platforms Grub modules installed in the target. The drawback is the > overwrite of Grub2 binaries tools during each "make install" command. This > drawback is not really important as it happens in the same package. This is > the best option to avoid unnecessary and more complexity to this package. > > Yann adds also mixes fixes, like no semi-colons but separate lines, or > using && not sime-colon, and the calls to MESSAGE to explicit the different > step of the parallel build. Yann will ask to have these in a separate patch, I'm pretty sure (as I would request the same). Thanks! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot