From: Peter Seiderer <ps.report@gmx.net>
To: "Köry Maincent" <kory.maincent@bootlin.com>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
"Walter, Stefan" <stefan.walter@iml.fraunhofer.de>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] Boot process stuck at "GRUB loading.." since 2021.02.1
Date: Fri, 22 Oct 2021 19:42:17 +0200 [thread overview]
Message-ID: <20211022194217.4a77a963@gmx.net> (raw)
In-Reply-To: <20211022114824.4e9ae29f@kmaincent-XPS-13-7390>
Hello Köry, *,
On Fri, 22 Oct 2021 11:48:24 +0200, Köry Maincent <kory.maincent@bootlin.com> wrote:
> Yann, Peter, Stefan, all
>
> On Thu, 21 Oct 2021 19:59:01 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>
> > > <stefan.walter@iml.fraunhofer.de> wrote: The host-grub2 modules build can
> > > be fixed by the following patch:
> > >
> > > --- a/boot/grub2/grub2.mk
> > > +++ b/boot/grub2/grub2.mk
> > > @@ -125,7 +125,9 @@ GRUB2_TUPLES-$(BR2_TARGET_GRUB2_ARM64_EFI) += arm64-efi
> > > # use the cross compile variant to ensure grub2 builds
> > >
> > > HOST_GRUB2_CONF_ENV = \
> > > - CPP="$(HOSTCC) -E"
> > > + CPP="$(HOSTCC) -E" \
> > > + CFLAGS="$(HOST_CFLAGS) -Os" \
> > > + CPPFLAGS="$(HOST_CPPFLAGS) -Os"
> >
> > Sure, but why do we even need to build the modules in the host version
> > to begin with?
>
> I agree. This patch seems not relevant. We build host-grub2 only for the
> binaries. Stefan should use the target modules directory and not the one
> from the host.
So Stefan use-case only worked by chance in the past (because host/target
shared the same arch x86)...
>
> > We should probably build the host version with --with-platform=none I
> > think.
> >
> > Yes, we do currently use cdboot.img from the host, but that is probably
> > a mistake and a remnant for long ago... Instead, I think we should only
> > used modules from the target build.
One could argue that it would be a nice feature to have the host-tools and
the (cross-compiled) target-modules in one place...
>
> I will add the none platform and the right cdboot.img path into my v2 grub patch
> series.
...but I am fine with this solution ;-)
Regards,
Peter
>
> Regards,
> Köry
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-22 17:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 20:36 [Buildroot] Boot process stuck at "GRUB loading.." since 2021.02.1 Walter, Stefan
2021-10-07 21:50 ` Peter Seiderer
2021-10-08 14:27 ` Walter, Stefan
2021-10-08 17:25 ` Peter Seiderer
2021-10-11 12:23 ` Walter, Stefan
2021-10-11 17:29 ` Walter, Stefan
2021-10-18 22:22 ` Peter Seiderer
2021-10-19 15:17 ` Walter, Stefan
2021-10-19 21:02 ` Peter Seiderer
2021-10-21 17:59 ` Yann E. MORIN
2021-10-22 9:48 ` Köry Maincent
2021-10-22 17:42 ` Peter Seiderer [this message]
2021-10-08 16:53 ` Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022194217.4a77a963@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=stefan.walter@iml.fraunhofer.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox