From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Stephan Hoffmann <sho@relinux.de>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/2] package/gtest: fix gtest.pc/gmock.pc library names for the debug build
Date: Sun, 24 Oct 2021 16:02:43 +0200 [thread overview]
Message-ID: <20211024160243.1ed3c012@windsurf> (raw)
In-Reply-To: <20211022190702.7782-1-ps.report@gmx.net>
On Fri, 22 Oct 2021 21:07:01 +0200
Peter Seiderer <ps.report@gmx.net> wrote:
> Fixes:
>
> - http://autobuild.buildroot.org/results/e1bb8aa1de310f3d27b74ec7d8748d170ad444e2
>
> >>> libcamera 40f5fddca7f774944a53f58eeaebc4db79c373d8 Building
> [...]
> [114/123] Linking target src/lc-compliance/lc-compliance
> FAILED: src/lc-compliance/lc-compliance
> [...]
> .../host/lib/gcc/arm-buildroot-linux-uclibcgnueabi/10.3.0/../../../../arm-buildroot-linux-uclibcgnueabi/bin/ld: cannot find -lgtest
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...test.pc-gmock.pc-library-names-for-t.patch | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 package/gtest/0001-pkg-config-fix-gtest.pc-gmock.pc-library-names-for-t.patch
Series applied, thanks! To be honest, I always found it very weird this
choice of some upstream project to have a different library name
depending on whether it is built with/without debug. But oh well, if
that's how gtest wants it...
Note that you have to sign the Google CLA if you want them to consider
your patch on gtest.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-24 14:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 19:07 [Buildroot] [PATCH v1 1/2] package/gtest: fix gtest.pc/gmock.pc library names for the debug build Peter Seiderer
2021-10-22 19:07 ` [Buildroot] [PATCH v1 2/2] package/libcamera: add lc-compliance test application option Peter Seiderer
2021-10-23 20:30 ` Kieran Bingham
2021-10-24 14:02 ` Thomas Petazzoni [this message]
2021-10-26 12:11 ` [Buildroot] [PATCH v1 1/2] package/gtest: fix gtest.pc/gmock.pc library names for the debug build Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211024160243.1ed3c012@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=ps.report@gmx.net \
--cc=sho@relinux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox