From: Adam Duskett <aduskett@gmail.com>
To: buildroot@buildroot.org
Cc: Daniel Price <daniel.price@gmail.com>,
Anisse Astier <anisse@astier.eu>,
Romain Naour <romain.naour@gmail.com>,
Martin Bark <martin@barkynet.com>,
Adam Duskett <aduskett@gmail.com>
Subject: [Buildroot] [PATCH 1/1] package/qemu: bump host gcc requirements: propagate to all reverse dependencies
Date: Mon, 25 Oct 2021 13:00:49 -0700 [thread overview]
Message-ID: <20211025200049.381077-1-aduskett@gmail.com> (raw)
qemu now requires gcc >= 7.5, however, as there is no BR2_HOST_GCC_AT_LEAST_7_5,
set the host gcc requirements to 8.
In addition:
- Propagate the host gcc dependency to gobject-introspection as it was missing
to begin with.
- Propagate the host gcc dependency to nodejs
- Add a missing comment in package/qemu/Config.in.host explaining the host gcc
requirements if host gcc < 8.
Fixes:
http://autobuild.buildroot.org/results/32b7fee1f8cda2290fd4bd8ac9fe78bacb25b652
Signed-off-by: Adam Duskett <aduskett@gmail.com>
---
package/gobject-introspection/Config.in | 3 ++-
package/nodejs/Config.in | 6 +++---
package/qemu/Config.in.host | 7 ++++++-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
index bacf44363c..15b6bc3bfa 100644
--- a/package/gobject-introspection/Config.in
+++ b/package/gobject-introspection/Config.in
@@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
# compile errors with locale.c. As such, require 4.9 until this
# can be verified.
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+ depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
depends on BR2_TOOLCHAIN_USES_GLIBC
# gobject-introspection does not require python3 to run on the
# target; however, because the tools run in a qemu wrapper, a
@@ -41,7 +42,7 @@ comment "gobject-introspection needs python3"
depends on !BR2_PACKAGE_PYTHON3
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
-comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9"
+comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 8"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_USES_GLIBC || \
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index 771f735e97..99c76bc3de 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -8,18 +8,18 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_HAS_SYNC_4
depends on BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET
-comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar"
+comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar, host gcc >= 8"
depends on BR2_USE_MMU
depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
- !BR2_HOST_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
+ !BR2_HOST_GCC_AT_LEAST_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
config BR2_PACKAGE_NODEJS
bool "nodejs"
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
- depends on BR2_HOST_GCC_AT_LEAST_7
+ depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
depends on BR2_USE_WCHAR
# uses fork()
diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
index a5b38c081b..df5d921125 100644
--- a/package/qemu/Config.in.host
+++ b/package/qemu/Config.in.host
@@ -37,7 +37,7 @@ config BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
config BR2_PACKAGE_HOST_QEMU
bool "host qemu"
depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
- depends on BR2_HOST_GCC_AT_LEAST_7
+ depends on BR2_HOST_GCC_AT_LEAST_8
select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \
if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE && BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE \
@@ -50,6 +50,11 @@ config BR2_PACKAGE_HOST_QEMU
http://www.qemu.org
+comment "host-qemu needs a host gcc >= 8"
+ depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || \
+ BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORT
+ depends on !BR2_HOST_GCC_AT_LEAST_8
+
if BR2_PACKAGE_HOST_QEMU
comment "Emulators selection"
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next reply other threads:[~2021-10-25 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 20:00 Adam Duskett [this message]
2021-10-25 20:19 ` [Buildroot] [PATCH 1/1] package/qemu: bump host gcc requirements: propagate to all reverse dependencies Arnout Vandecappelle
2021-10-25 20:32 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025200049.381077-1-aduskett@gmail.com \
--to=aduskett@gmail.com \
--cc=anisse@astier.eu \
--cc=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=martin@barkynet.com \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox