Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Adam Duskett <aduskett@gmail.com>
Cc: Daniel Price <daniel.price@gmail.com>,
	Grzegorz Blach <grzegorz@blach.pl>,
	Anisse Astier <anisse@astier.eu>, Asaf Kahlon <asafka7@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	Martin Bark <martin@barkynet.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/qemu: bump host gcc requirements: propagate to all reverse dependencies
Date: Mon, 25 Oct 2021 23:02:41 +0200	[thread overview]
Message-ID: <20211025210241.GV2400@scaer> (raw)
In-Reply-To: <20211025202002.589440-1-aduskett@gmail.com>

Adam, All,

On 2021-10-25 13:20 -0700, Adam Duskett spake thusly:
> qemu now requires gcc >= 7.5, however, as there is no BR2_HOST_GCC_AT_LEAST_7_5,
> set the host gcc requirements to 8.
> 
> In addition:
>   - Add a missing comment in package/qemu/Config.in.host explaining the host gcc
>     requirements if host gcc < 8.
> 
> Fixes:
> http://autobuild.buildroot.org/results/32b7fee1f8cda2290fd4bd8ac9fe78bacb25b652
> Signed-off-by: Adam Duskett <aduskett@gmail.com>

Applied to master, with a fwew fixes:

  - target qemu also impacted
  - propagate to libvirt, gst1-python
  - reword commit log that 7.5 is the last 7.x release

Thanks!

Regards,
Yann E. MORIN.

> ---
> changes v1 -> v2:
>   - rebase against commit 17358061ad2b58d3eb96ea8c5631e235a484ac87
> 
>  package/gobject-introspection/Config.in | 6 +++---
>  package/nodejs/Config.in                | 6 +++---
>  package/python-bluezero/Config.in       | 6 +++---
>  package/python-gobject/Config.in        | 6 +++---
>  package/qemu/Config.in.host             | 7 ++++++-
>  5 files changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
> index c631c84755..42250eb776 100644
> --- a/package/gobject-introspection/Config.in
> +++ b/package/gobject-introspection/Config.in
> @@ -13,7 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
>  	# compile errors with locale.c. As such, require 4.9 until this
>  	# can be verified.
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> -	depends on BR2_HOST_GCC_AT_LEAST_7 # host-qemu
> +	depends on BR2_HOST_GCC_AT_LEAST_8 # host-qemu
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>  	# gobject-introspection does not require python3 to run on the
>  	# target; however, because the tools run in a qemu wrapper, a
> @@ -42,9 +42,9 @@ comment "gobject-introspection needs python3"
>  	depends on !BR2_PACKAGE_PYTHON3
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>  
> -comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> +comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 8"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> -		!BR2_HOST_GCC_AT_LEAST_7
> +		!BR2_HOST_GCC_AT_LEAST_8
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index 771f735e97..99c76bc3de 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -8,18 +8,18 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET
>  
> -comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar"
> +comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar, host gcc >= 8"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
>  	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> -		!BR2_HOST_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
> +		!BR2_HOST_GCC_AT_LEAST_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
>  
>  config BR2_PACKAGE_NODEJS
>  	bool "nodejs"
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
>  	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
> -	depends on BR2_HOST_GCC_AT_LEAST_7
> +	depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
>  	depends on BR2_USE_WCHAR
>  	# uses fork()
> diff --git a/package/python-bluezero/Config.in b/package/python-bluezero/Config.in
> index 3d40b1e275..d617b96d67 100644
> --- a/package/python-bluezero/Config.in
> +++ b/package/python-bluezero/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
>  	bool "python-bluezero"
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # python-gobject -> gobject-introspection
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # python-gobject -> gobject-introspection
> -	depends on BR2_HOST_GCC_AT_LEAST_7 # python-gobject -> gobject-introspection -> host-qemu
> +	depends on BR2_HOST_GCC_AT_LEAST_8 # python-gobject -> gobject-introspection -> host-qemu
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # python-gobject -> gobject-introspection
>  	depends on BR2_PACKAGE_PYTHON3
>  	select BR2_PACKAGE_DBUS # runtime
> @@ -13,9 +13,9 @@ config BR2_PACKAGE_PYTHON_BLUEZERO
>  
>  	  https://github.com/ukBaz/python-bluezero
>  
> -comment "python-bluezero needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> +comment "python-bluezero needs a glibc toolchain, gcc >= 4.9, host gcc >= 8"
>  	depends on BR2_PACKAGE_PYTHON3
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> -		!BR2_HOST_GCC_AT_LEAST_7
> +		!BR2_HOST_GCC_AT_LEAST_8
> diff --git a/package/python-gobject/Config.in b/package/python-gobject/Config.in
> index 910f990026..efc781a1ff 100644
> --- a/package/python-gobject/Config.in
> +++ b/package/python-gobject/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
>  	depends on BR2_USE_MMU # libglib2, gobject-introspection
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS # gobject-introspection
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # gobject-introspection
> -	depends on BR2_HOST_GCC_AT_LEAST_7 # gobject-introspection -> host-qemu
> +	depends on BR2_HOST_GCC_AT_LEAST_8 # gobject-introspection -> host-qemu
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # gobject-introspection
>  	depends on BR2_PACKAGE_PYTHON3 # gobject-introspection
>  	select BR2_PACKAGE_GOBJECT_INTROSPECTION
> @@ -13,9 +13,9 @@ config BR2_PACKAGE_PYTHON_GOBJECT
>  
>  	  https://wiki.gnome.org/action/show/Projects/PyGObject
>  
> -comment "python-gobject needs a glibc toolchain, gcc >= 4.9, host gcc >= 7"
> +comment "python-gobject needs a glibc toolchain, gcc >= 4.9, host gcc >= 8"
>  	depends on BR2_USE_MMU
>  	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
>  	depends on !BR2_TOOLCHAIN_USES_GLIBC || \
>  		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
> -		!BR2_HOST_GCC_AT_LEAST_7
> +		!BR2_HOST_GCC_AT_LEAST_8
> diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host
> index a5b38c081b..df5d921125 100644
> --- a/package/qemu/Config.in.host
> +++ b/package/qemu/Config.in.host
> @@ -37,7 +37,7 @@ config BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
>  config BR2_PACKAGE_HOST_QEMU
>  	bool "host qemu"
>  	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
> -	depends on BR2_HOST_GCC_AT_LEAST_7
> +	depends on BR2_HOST_GCC_AT_LEAST_8
>  	select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \
>  		if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE && BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
>  	select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE \
> @@ -50,6 +50,11 @@ config BR2_PACKAGE_HOST_QEMU
>  
>  	  http://www.qemu.org
>  
> +comment "host-qemu needs a host gcc >= 8"
> +	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || \
> +		BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORT
> +	depends on !BR2_HOST_GCC_AT_LEAST_8
> +
>  if BR2_PACKAGE_HOST_QEMU
>  
>  comment "Emulators selection"
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-10-25 21:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 20:20 [Buildroot] [PATCH v2 1/1] package/qemu: bump host gcc requirements: propagate to all reverse dependencies Adam Duskett
2021-10-25 21:02 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025210241.GV2400@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=aduskett@gmail.com \
    --cc=anisse@astier.eu \
    --cc=asafka7@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=daniel.price@gmail.com \
    --cc=grzegorz@blach.pl \
    --cc=martin@barkynet.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox