Re: [Buildroot] [PATCH 1/1] package/oprofile: needs zlib

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Buildroot Mailing List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/oprofile: needs zlib
Date: Wed, 10 Nov 2021 10:12:03 +0100	[thread overview]
Message-ID: <20211110091203.GD2084998@scaer> (raw)
In-Reply-To: <CAPi7W82g-5Bs1gxUOqXwgqnx8EgBgENYwGLbAX6XvVfCd5+s5Q@mail.gmail.com>

Fabrice, All,

On 2021-11-09 23:37 +0100, Fabrice Fontaine spake thusly:
> Le mar. 9 nov. 2021 à 23:26, Yann E. MORIN <yann.morin.1998@free.fr> a écrit :
> > On 2021-11-09 22:40 +0100, Arnout Vandecappelle spake thusly:
> > > On 01/11/2021 09:47, Thomas Petazzoni wrote:
> > > >On Sat, 30 Oct 2021 23:47:34 +0200
> > > >Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > > >>oprofile needs zlib to avoid the following build failure which is, for
> > > >>an unknown reason, only raised since August 2021:
> > > >I don't really like changes that are made "for an unknown reason".
> > >  Note that in this configuration, zlib is not selected (*), but apparently
> > > libbfd is still built with zlib support...
> > That's because binutils (at least 2.36.1) ships with a bundled copy
> > that it builds:
> >
> >     >>> binutils 2.36.1 Building
> >     [...] /usr/bin/make -j9 LIBS= MAKEINFO=true -C /home/ymorin/dev/buildroot/O/build/binutils-2.36.1/
> >     make[3]: Nothing to be done for 'all-target'.
> >     Configuring in ./etc
> >     configure: creating cache ./config.cache
> >     checking for a BSD-compatible install... /usr/bin/install -c
> >     configure: updating cache ./config.cache
> >     configure: creating ./config.status
> >     config.status: creating Makefile
> >     make[4]: Nothing to be done for 'all'.
> >     Configuring in ./zlib
> >     [...]
> >
> > And hence libbfd is built against the bundled libz, which being what
> > autotools call a convenience library, is not isntalled.

... and it is also not installed because we anyway only do a partial
install of select libraries.

> > And this bundled copy is always built, even if one is already present in
> > the system (i.e. with zlib enabled in the configuration).
> From my understanding of binutils's configure.ac, we should be able to
> disable the bundled copy through --with-system-lib which is available
> since version 2.26 and
> https://github.com/bminor/binutils-gdb/commit/cf39cfc52ebd683d55fc396a77355f34b5094c04:

Oh yes, I forgot to mention that yesterday. Yes, this is I believe the
best solution: binutils should always depend on zlib (it currently only
conditionally depends on it).

Care to send the patch, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot