Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Seiderer <ps.report@gmx.net>
Cc: Martin Bark <martin@barkynet.com>,
	Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
	Julien Grossholtz <julien.grossholtz@openest.io>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH/next v1 4/7] package/rpi-bt-firmware: bump version to 3888ba2
Date: Fri, 12 Nov 2021 23:18:07 +0100	[thread overview]
Message-ID: <20211112221807.GH247986@scaer> (raw)
In-Reply-To: <20211111200439.15379-4-ps.report@gmx.net>

Peter, All,

On 2021-11-11 21:04 +0100, Peter Seiderer spake thusly:
> Changelog (since 883b726):
> 
>   - 3e020f7 Add 43436S firmware
>             Future Zero 2 W boards will have an alternative version of 43436
>             that should have different firmware, named brcmfmac43436s-sdio.
> 
>   - 3888ba2 Merge pull request #18 from HiassofT/43436S
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to next, thanks. But see below for a comment of mone...

> ---
>  package/rpi-bt-firmware/rpi-bt-firmware.hash | 2 +-
>  package/rpi-bt-firmware/rpi-bt-firmware.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rpi-bt-firmware/rpi-bt-firmware.hash b/package/rpi-bt-firmware/rpi-bt-firmware.hash
> index 3f37d964d0..7e60aa4632 100644
> --- a/package/rpi-bt-firmware/rpi-bt-firmware.hash
> +++ b/package/rpi-bt-firmware/rpi-bt-firmware.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  0e7fcfe75a8990815a184dc55f8fdf5d0644d351a15a7aef865ff90ff4ca8eb4  rpi-bt-firmware-883b72628de1d7efa45b421da0cbf175ac2374f8.tar.gz
> +sha256  9bd61431d42322eb0610bd7eed218da255c4472efc203be4332a0872bb562ade  rpi-bt-firmware-3888ba29898bb3f056d5f1eb283cb8de4c533bef.tar.gz
>  sha256  b16056fc91b82a0e3e8de8f86c2dac98201aa9dc3cbd33e8d38f1b087fcec30d  LICENCE.broadcom_bcm43xx
> diff --git a/package/rpi-bt-firmware/rpi-bt-firmware.mk b/package/rpi-bt-firmware/rpi-bt-firmware.mk
> index 13358b4fda..8d658ce435 100644
> --- a/package/rpi-bt-firmware/rpi-bt-firmware.mk
> +++ b/package/rpi-bt-firmware/rpi-bt-firmware.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RPI_BT_FIRMWARE_VERSION = 883b72628de1d7efa45b421da0cbf175ac2374f8
> +RPI_BT_FIRMWARE_VERSION = 3888ba29898bb3f056d5f1eb283cb8de4c533bef
>  RPI_BT_FIRMWARE_SITE = $(call github,LibreELEC,brcmfmac_sdio-firmware-rpi,$(RPI_BT_FIRMWARE_VERSION))

Why do we have two packages that come from the same upstream repository,
at the same version, and basically just both copy a bunch of files?

Can't we have a single package instead, that also is named after the
upstream repository, and that has two options, each to install either
the BT or WiFi firmwares?

Regards,
Yann E. MORIN.

>  RPI_BT_FIRMWARE_LICENSE = PROPRIETARY
>  RPI_BT_FIRMWARE_LICENSE_FILES = LICENCE.broadcom_bcm43xx
> -- 
> 2.33.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2021-11-12 22:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 20:04 [Buildroot] [PATCH/next v1 1/7] configs/raspberrypi*: bump kernel version to 9878a11 (5.10.78) Peter Seiderer
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 2/7] package/rpi-firmware: bump version to fa9a006 Peter Seiderer
2021-11-12 22:13   ` Yann E. MORIN
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 3/7] package/rpi-userland: bump version to bab9bf8 Peter Seiderer
2021-11-12 22:14   ` Yann E. MORIN
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 4/7] package/rpi-bt-firmware: bump version to 3888ba2 Peter Seiderer
2021-11-12 22:18   ` Yann E. MORIN [this message]
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 5/7] package/rpi-wifi-firmware: " Peter Seiderer
2021-11-12 22:18   ` Yann E. MORIN
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 6/7] board/raspberrypi/readme.txt: add missing dtb files Peter Seiderer
2021-11-12 22:18   ` Yann E. MORIN
2021-11-11 20:04 ` [Buildroot] [PATCH/next v1 7/7] board/raspberrypi: add Raspberry Pi Zero 2 W Peter Seiderer
2021-11-12 22:19   ` Yann E. MORIN
2021-11-12 22:13 ` [Buildroot] [PATCH/next v1 1/7] configs/raspberrypi*: bump kernel version to 9878a11 (5.10.78) Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211112221807.GH247986@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=julien.grossholtz@openest.io \
    --cc=mahyar.koshkouei@gmail.com \
    --cc=martin@barkynet.com \
    --cc=ps.report@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox