From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Tan Xiaofan <xfan1024@live.com>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] fs: allow strip binaries when create rootfs
Date: Fri, 12 Nov 2021 23:36:03 +0100 [thread overview]
Message-ID: <20211112233603.274a7af2@windsurf> (raw)
In-Reply-To: <20211110190005.GN2084998@scaer>
On Wed, 10 Nov 2021 20:00:05 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> This is a simple approach to the problem, indeed. However, I think the
> choice is not needed: just keep the boolean option, and move the whole
> stripping out of target-finalize and into the fs creation step.
>
> Thoughts?
I'm not sure about this change. I understand that's it's an easy way to
have all binaries unstripped on the build machine, while having them
stripped on the target.
However, it makes $(TARGET_DIR) move further away from what will
actually end up on the target. I tend (and I guess a number of users as
well) to look at $(O)/target to see what my root filesystem looks like,
what it contains, etc. So all the post-processing steps that we add in
the root filesystem generation logic kind of "hides" this
post-processing from the eyes of the person looking at $(O)/target.
Furthermore, I believe this change is going to break "make size-stats",
because make size-stats looks at the size of files installed in
$(O)/target.
I think the long term idea instead was to install all packages to
STAGING_DIR, so that we have an unstripped installation of all packages.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-12 22:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 16:10 [Buildroot] [PATCH] fs: allow strip binaries when create rootfs Tan Xiaofan
2021-11-10 19:00 ` Yann E. MORIN
2021-11-11 3:16 ` [Buildroot] 回复: " Tan Xiaofan
2021-11-12 22:36 ` Thomas Petazzoni [this message]
2022-07-25 19:46 ` [Buildroot] " Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211112233603.274a7af2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=xfan1024@live.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox