From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE39CC433EF for ; Sat, 13 Nov 2021 14:21:38 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F98360F44 for ; Sat, 13 Nov 2021 14:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F98360F44 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=buildroot.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4F5BC6068C; Sat, 13 Nov 2021 14:21:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PI9U4wovrxXa; Sat, 13 Nov 2021 14:21:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id A7107606BB; Sat, 13 Nov 2021 14:21:36 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 37CF71BF349 for ; Sat, 13 Nov 2021 14:21:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 26AF6405BE for ; Sat, 13 Nov 2021 14:21:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZcYdBm8vM4Bc for ; Sat, 13 Nov 2021 14:21:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by smtp4.osuosl.org (Postfix) with ESMTPS id EF1E74058F for ; Sat, 13 Nov 2021 14:21:33 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 093F81C0005; Sat, 13 Nov 2021 14:21:30 +0000 (UTC) Date: Sat, 13 Nov 2021 15:21:30 +0100 From: Thomas Petazzoni To: "Yann E. MORIN" Message-ID: <20211113152130.560f51cf@windsurf> In-Reply-To: <20211113124234.524796-1-yann.morin.1998@free.fr> References: <20211113124234.524796-1-yann.morin.1998@free.fr> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH] support/pkg-stats: support values with an equal sign in them X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Sat, 13 Nov 2021 13:42:34 +0100 "Yann E. MORIN" wrote: > The heuristic to extract the various variables of interest is pretty > crude: we filter on variables ending with certain suffixes (like > '%_VERSION' to get the version strings). > > However, in doing so, we may dump variables that are not actual package > versions (especially with br2-external trees), and those may contain one > or more equal sign. And anyway, an actual package version string may > very well contain an equal sign too. > > But the current situation is that the output of 'printvars' is split on > all equal signs, which will not fit in the 2-tuple we assign the result, > thus causing an exception. > > Fix that by limiting to a single split. > > Reported-by: Thomas Petazzoni > Signed-off-by: Yann E. MORIN > --- > support/scripts/pkg-stats | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master and next, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot