Re: [Buildroot] [PATCH 1/1] package/harfbuzz: bump to version 3.1.1

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Giulio,

On Mon,  8 Nov 2021 19:35:19 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Bump to version 3.1.1 by:
> - requiring BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 instead of _4_8 in this
> package taking care of reverse dependencies, since now harfbuzz requires
> gcc 4.9 to be built successfully.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Thanks for this patch. Unfortunately, it has one issue: you only took
care of the first-order reverse dependencies of harfbuzz, i.e the
packages that directly select harfbuzz. But you didn't look at the
reverse dependencies of these reverse dependencies. For example, in
this patch, you're changing pango to require gcc >= 4.9. But you didn't
look at the packages that themselves select pango. They also need to be
updated accordingly!


> diff --git a/package/pango/Config.in b/package/pango/Config.in
> index cf5170c8f3..ff529ab0dc 100644
> --- a/package/pango/Config.in
> +++ b/package/pango/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_PANGO
>  	depends on BR2_USE_MMU # glib2
>  	depends on BR2_INSTALL_LIBSTDCPP # freetype support
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # harfbuzz
> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # harfbuzz
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # harfbuzz
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_LIBFRIBIDI
>  	select BR2_PACKAGE_EXPAT

You also forgot to update the Config.in comment in this file.

Could you revisit this and provide an improved version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot