From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7"
Date: Fri, 19 Nov 2021 18:10:46 +0100 [thread overview]
Message-ID: <20211119171046.GQ247986@scaer> (raw)
In-Reply-To: <20211119165458.2410686-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-11-19 17:54 +0100, Fabrice Fontaine spake thusly:
> This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move
> these selects on boost side as the build failure was raised with gcc >=
> 7.
So, if I understand correctly, if we just apply this revert, but not the
following patch, we break the build again, right? If so, then it makes
the history not bi-sectable.
Instead, the boost patch must be applied first, and once that is done,
then we can apply this revert.
If the above is correct, just say so, we can re-order the patches when
applying...
Regards,
Yann E. MORIN.
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/log4cxx/Config.in | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in
> index 27a5f06988..6f1956f829 100644
> --- a/package/log4cxx/Config.in
> +++ b/package/log4cxx/Config.in
> @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX
> select BR2_PACKAGE_APR_UTIL
> select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> help
> Apache log4cxx is a logging framework for C++ patterned
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-19 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 16:54 [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine
2021-11-19 16:54 ` [Buildroot] [PATCH 2/2] package/boost: threads needs date-time Fabrice Fontaine
2021-11-19 17:10 ` Yann E. MORIN [this message]
2021-11-19 17:31 ` [Buildroot] [PATCH 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine
2021-11-19 17:43 ` Fabrice Fontaine
2021-11-19 17:50 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211119171046.GQ247986@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox