From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2, 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7"
Date: Sun, 21 Nov 2021 14:57:41 +0100 [thread overview]
Message-ID: <20211121145741.1fa4dffb@windsurf> (raw)
In-Reply-To: <20211119175553.2413433-1-fontaine.fabrice@gmail.com>
On Fri, 19 Nov 2021 18:55:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move
> these selects on boost side as the build failure was raised with gcc >=
> 7 (making this commit a "no-op"). Indeed, the build failure is raised
> with cmake < 3.21.3, because cmake assumed that boost thread depends on
> date-time until
> https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b.
I don't understand why you say this commit is a no-op. It clearly
isn't. In gcc < 7.x configurations, this commit ensures that boost
chrono and boost date-time are selected.
The fact that you realize later that the build failure occurred with
gcc >= 7.x, meaning this commit does not help fixing the issue does not
make this commit a no-op.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-21 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 17:55 [Buildroot] [PATCH v2, 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Fabrice Fontaine
2021-11-19 17:55 ` [Buildroot] [PATCH v2,2/2] package/boost: threads needs date-time Fabrice Fontaine
2021-11-21 19:43 ` [Buildroot] [PATCH v2, 2/2] " Thomas Petazzoni
2021-11-22 20:53 ` Arnout Vandecappelle
2021-11-23 11:24 ` Thomas Petazzoni
2021-11-21 13:57 ` Thomas Petazzoni [this message]
2022-01-13 22:14 ` [Buildroot] [PATCH v2, 1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" Thomas Petazzoni
2022-01-16 9:43 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121145741.1fa4dffb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox