From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Cyril Bur <cyrilbur@gmail.com>
Cc: Luca Ceresoli <luca@lucaceresoli.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH] Handle _LICENSE_FILES with full path
Date: Wed, 24 Nov 2021 20:41:27 +0100 [thread overview]
Message-ID: <20211124204127.493ffaa3@windsurf> (raw)
In-Reply-To: <20211124151827.1107e808@camb691.localdomain>
Hello Cyril,
On Wed, 24 Nov 2021 15:18:27 +0000
Cyril Bur <cyrilbur@gmail.com> wrote:
> legal-info currently assumes that a packages _LICENSE_FILES will be a
> path or a filename relative to the source of the package.
>
> There is nothing preventing _LICENSE_FILES from containing a full path,
> probably using _PKGDIR within the package .mk file. When this happens,
> the legal-info process simply adds the build directory on the front of
> the _LICENSE_FILES resulting in a failed cp of the file.
>
> This patch simply performs a check to see if the _LICENSE_FILES path
> with the build directory prepended exists (as is the case for all
> packages currently) and uses that. Otherwise it will assume that
> the _LICENSE_FILES file is a fullpath and attempt to use that.
>
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
Could you clarify the use case with a specific example ?
Thanks!
Thoimas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-24 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 15:18 [Buildroot] [RFC PATCH] Handle _LICENSE_FILES with full path Cyril Bur
2021-11-24 19:41 ` Thomas Petazzoni [this message]
2021-11-25 12:25 ` Cyril Bur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211124204127.493ffaa3@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=cyrilbur@gmail.com \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox