From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support
Date: Sun, 5 Dec 2021 11:09:14 +0100 [thread overview]
Message-ID: <20211205110914.2dbbf237@windsurf> (raw)
In-Reply-To: <20211205005412.2888068-7-james.hilliard1@gmail.com>
Hello James,
On Sat, 4 Dec 2021 17:54:12 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/network-manager/network-manager.mk | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index 14bf0d4dd1..7a268d72c8 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -112,6 +112,21 @@ else
> NETWORK_MANAGER_CONF_OPTS += --enable-polkit=no
> endif
>
> +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> +NETWORK_MANAGER_DEPENDENCIES += systemd
> +NETWORK_MANAGER_CONF_OPTS += \
> + --with-systemd-journal=yes \
=yes not needed
> + --with-config-logging-backend-default=journal \
> + --with-session-tracking=systemd \
> + --with-suspend-resume=systemd
> +else
> +NETWORK_MANAGER_CONF_OPTS += \
> + --with-systemd-journal=no \
--without-systemd-journal
> + --with-config-logging-backend-default=syslog \
> + --with-session-tracking=no \
--without-session-tracking
> + --with-suspend-resume=upower
Are you sure about this? We don't forcefully enable upower when systemd
is disabled, so is this working?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-12-05 10:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 0:54 [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 2/7] package/network-manager: add optional iwd support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 3/7] package/network-manager: add optional libaudit support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 4/7] package/network-manager: add optional libpsl support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 5/7] package/network-manager: add optional selinux support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 6/7] package/network-manager: add optional polkit support James Hilliard
2021-12-05 0:54 ` [Buildroot] [PATCH v2 7/7] package/network-manager: add optional systemd support James Hilliard
2021-12-05 10:09 ` Thomas Petazzoni [this message]
2021-12-05 11:14 ` James Hilliard
2021-12-05 10:08 ` [Buildroot] [PATCH v2 1/7] package/network-manager: bump to version 1.32.12 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211205110914.2dbbf237@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox