From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57155C433EF for ; Mon, 6 Dec 2021 21:45:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1EC9884BCC; Mon, 6 Dec 2021 21:45:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KT1RS_MhSGaj; Mon, 6 Dec 2021 21:45:38 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 7B70384BCA; Mon, 6 Dec 2021 21:45:37 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 8BD881BF334 for ; Mon, 6 Dec 2021 21:45:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7A67484BCA for ; Mon, 6 Dec 2021 21:45:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sQpqQ2iAY-6c for ; Mon, 6 Dec 2021 21:45:34 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [212.27.42.1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 57FD984BA9 for ; Mon, 6 Dec 2021 21:45:34 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:4835:cc5:af50:efe7]) (Authenticated sender: yann.morin.1998@free.fr) by smtp1-g21.free.fr (Postfix) with ESMTPSA id B6F7CB00BDA; Mon, 6 Dec 2021 22:45:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1638827131; bh=ypFQ7anRT7l6V6lr7Cz/57ESZfsQ5D9mokuMj1yS+RU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YEjCtHKDYXy6UG+6YJnZv/2XIMxY+rbpBgxLyicbXJq9s1sKQI89uS6OArCv5tN2e +3gB4QwOVvh2lGufElYe9VM4x1QUUxnQLfDAY5aAgz0FgcNV3VHvbC29qltvOepSax +8qHeVECG+sGnrbSlCg2QCvFMaIsvYaYYjE6IJorNI096BK3r8SHWdqZ5IpTJLbDsD Yc+ysZUIVfuF7AnsUxPz0TY8qSVhyrq45duv9kt3s7abPlO1JGhRcvUL9FlYz1owVh KhPxMPt693D1TXmN6BJHXjhWt5LfCyw5eX/j+0NmNjBKlPKY+frnAcH/QV0Ox3dLQt Eg8lBgaoARkhA== Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Mon, 06 Dec 2021 22:45:27 +0100 Date: Mon, 6 Dec 2021 22:45:27 +0100 From: "Yann E. MORIN" To: guillaume.bressaix@gmail.com Message-ID: <20211206214527.GD2603@scaer> References: <20211206193109.21218-1-guillaume.bressaix@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211206193109.21218-1-guillaume.bressaix@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) Subject: Re: [Buildroot] [PATCH v2 1/2] package/python-pybind: fix upgrade to version 2.6.1 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@busybox.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Guillaume, All, On 2021-12-06 20:31 +0100, guillaume.bressaix@gmail.com spake thusly: > From: "Guillaume W. Bres" > > The python 'setup.py' script needs header files > in $(@D)/pybind11 to work since v2.6.1, and these > files are generated by an internal minimalist cmake build. > > Fixes > http://autobuild.buildroot.net/results/b89f1de64b308dffa73675f1f31ccb0b7be5a10d > http://autobuild.buildroot.net/results/d0287b7f64f206b0f074908c5780a3632e0cb799 > http://autobuild.buildroot.net/results/27efb545a5a719a5581c8f746d3a3555ff4216ce > http://autobuild.buildroot.net/results/d2f0a0ad8f6c7178517df109e7d885dac9134c3a > http://autobuild.buildroot.net/results/b57e9a3279260dae4a590f9421238fcabb2f7cab > http://autobuild.buildroot.net/results/515e6f2fc6b5780260d98d6bb52b541ce4bf1afe > http://autobuild.buildroot.net/results/d89c4ecc81222d4f80c951da2232d2e393fa1c69 > > Signed-off-by: Guillaume W. Bres > > --- > This remains a python-package. > > 'python setup.py' actually hardcodes a system call to cmake now, > which seems dirty at first. But if we have a cmake env when they > do that, the install variables are passed and installation > is smooth. They probably introduced this call to make setup.py > self sufficient, as most people install this package from 'pip'. > > --- > package/python-pybind/python-pybind.mk | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/package/python-pybind/python-pybind.mk b/package/python-pybind/python-pybind.mk > index a6a1bdb976..bfd7f6f59a 100644 > --- a/package/python-pybind/python-pybind.mk > +++ b/package/python-pybind/python-pybind.mk > @@ -9,5 +9,12 @@ PYTHON_PYBIND_SITE = $(call github,pybind,pybind11,v$(PYTHON_PYBIND_VERSION)) > PYTHON_PYBIND_LICENSE = BSD-3-Clause > PYTHON_PYBIND_LICENSE_FILES = LICENSE > PYTHON_PYBIND_SETUP_TYPE = setuptools > +PYTHON_PYBIND_INSTALL_STAGING = YES > + > +# every single 'python setup.py' call actually calls cmake > +# internally, to populate $(@D)/pybind11 with build requirements. > +# If we have a host-cmake env at that moment, > +# then the final installation paths are properly defined > +PYTHON_PYBIND_DEPENDENCIES = host-cmake We do not hard-code a dependency to host-cmake, in case the system cmake is sufficient. Instead, we use $(BR2_CMAKE_HOST_DEPENDENCY) which is set appropriately. Regards, Yann E. MORIN. > $(eval $(python-package)) > -- > 2.20.1 > -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot