From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cups-pk-helper: fix dependencies
Date: Sat, 18 Dec 2021 22:43:08 +0100 [thread overview]
Message-ID: <20211218214308.GP2603@scaer> (raw)
In-Reply-To: <20211217225416.107885-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-12-17 23:54 +0100, Fabrice Fontaine spake thusly:
> Fix dependencies which are wrong since the addition of the package in
> commit e13c9ccf436cf13b53bec6933e5be4bb071cfad9 resulting in the
> following build failure:
>
> Makefile:587: *** duktape is in the dependency chain of polkit that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop.
>
> Fixes:
> - http://autobuild.buildroot.org/results/706a09b245880e99109a4cc99faffe83f458afc4
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/cups-pk-helper/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/cups-pk-helper/Config.in b/package/cups-pk-helper/Config.in
> index 63a0d3acd8..113f433795 100644
> --- a/package/cups-pk-helper/Config.in
> +++ b/package/cups-pk-helper/Config.in
> @@ -1,8 +1,10 @@
> config BR2_PACKAGE_CUPS_PK_HELPER
> bool "cups-pk-helper"
> + depends on BR2_USE_MMU
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # polkit -> c++17
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, polkit
> depends on BR2_USE_WCHAR # libglib2
> + depends on !BR2_STATIC_LIBS # polkit -> duktape
> depends on BR2_PACKAGE_CUPS
> select BR2_PACKAGE_POLKIT
> help
> @@ -11,7 +13,7 @@ config BR2_PACKAGE_CUPS_PK_HELPER
>
> https://wiki.freedesktop.org/www/Software/cups-pk-helper/
>
> -comment "cups-pk-helper support needs a toolchain with threads, wchar, gcc >= 7"
> +comment "cups-pk-helper support needs a toolchain with threads, wchar, dynamic library, gcc >= 7"
> depends on BR2_USE_MMU
> depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
> - !BR2_TOOLCHAIN_HAS_THREADS
> + !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2021-12-18 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 22:54 [Buildroot] [PATCH 1/1] package/cups-pk-helper: fix dependencies Fabrice Fontaine
2021-12-18 21:43 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211218214308.GP2603@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox