Re: [Buildroot] [PATCH 3/3] fs/dracut: new fs type

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thierry, All,

On 2021-12-19 07:55 +0100, Thierry Bultel spake thusly:
> >>> You should also check then if it gets properly updated by
> >>>support/misc/relocate-sdk.sh (I think yes).
> >>I am sorry, but I do not see the point here, would you mind explain
> >>please ?
> >
> > If there's such a wrapper script that sets the environment variables
> >correctly, the idea is to be able to use that as part of the SDK. That
> >also means it must be possible to move it to a different place. Since it
> >contains hardcoded paths to HOST_DIR, these need to be change when the SDK
> >is relocated. The relocate-sdk.sh script should do that, but it's
> >important to check that indeed it does.
> 
> I probably miss something here. Is it a bad idea to -not- use hardcoded
> paths in the wrapper script, but environment variables instead ?
> It should be something like:
> 
> -------------
> #!/bin/bash
> set -e
> 
> if [ -z "$*" ]; then
>     echo "No argument supplied"
>     exit
> fi
> 
> DRACUT_LDD=${TARGET_CROSS}ldd \
> DRACUT_INSTALL="${HOST_DIR}/lib/dracut/dracut-install" \
> dracutbasedir=${HOST_DIR}/usr/lib/dracut \
> dracutsysrootdir=${TARGET_DIR} \
> ${HOST_DIR}/bin/dracut "$@"
> ----------

The thing is, with the SDK, those variables are not set.

  - HOST_DIR can be easily derived; it is: $(dirname $(dirname "${0}"))
    or a little be simpler: $(dirname "${0%/*}")

  - TARGET_CROSS can probably be derived somehow, but not even sure...

  - TAGET_DIR has to be specified explicitly.

So, I think for now it would be over-engineering to try and catter for
the SDK; this can be acted upon later...

Regards,
Yann E. MORIN.

> So that should not impact the relocation ...
> 
> By the way, in cpio.mk, I also had to
> 
> export TARGET_CROSS
> 
> 
> Regards
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot