Re: [Buildroot] [PATCH 1/1] package/zziplib: fix static build failure with mpd

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Andreas,

On Fri, 24 Dec 2021 17:21:52 +0100
Andreas Ziegler <br015@umbiko.net> wrote:

> The latest released version of zziplib copies static libraries with appended 
> major version, but omits creating the necessary links to the base file names. 
> This prevents the linker to find the libraries via the search path. 
> 
> There is a discussion upstream: https://github.com/gdraheim/zziplib/issues/117
> 
> Update zzip/CMakeLists.txt to the current master, version a32538e to enable 
> creation of symlinks. 
> 
> This resolves the following autobuild issue:
> 
> http://autobuild.buildroot.net/results/ba711034c0abe980f677e26de41739223e2f66e9
> 
> Signed-off-by: Andreas Ziegler <br015@umbiko.net>
> ---
>  ...01-update-zzip-cmakelists-to-a32538e.patch | 220 ++++++++++++++++++
>  1 file changed, 220 insertions(+)
>  create mode 100644 package/zziplib/0001-update-zzip-cmakelists-to-a32538e.patch
> 
> diff --git a/package/zziplib/0001-update-zzip-cmakelists-to-a32538e.patch b/package/zziplib/0001-update-zzip-cmakelists-to-a32538e.patch
> new file mode 100644
> index 0000000000..1ed9243f69
> --- /dev/null
> +++ b/package/zziplib/0001-update-zzip-cmakelists-to-a32538e.patch
> @@ -0,0 +1,220 @@
> +--- zziplib-0.13.72/zzip/CMakeLists.txt
> ++++ zziplib-a32538e/zzip/CMakeLists.txt

Thanks a lot for looking into this build issue!

However, we want patches to have a proper description and
Signed-off-by. But it's not really nice to just have a large patch that
updates file XYZ to version ABC. What about backporting the few
specific patches that are needed?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot