Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Tudor Barbu <tudor.barbu@keysight.com>
Cc: Tudor Barbu via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/poco: bump version to 1.11.1
Date: Fri, 24 Dec 2021 19:04:07 +0100	[thread overview]
Message-ID: <20211224190407.1a29db0e@windsurf> (raw)
In-Reply-To: <SJ0PR17MB54938C9DC46497D9C09DA979937C9@SJ0PR17MB5493.namprd17.prod.outlook.com>

Hello Tudor,

On Tue, 21 Dec 2021 11:48:05 +0000
Tudor Barbu via buildroot <buildroot@buildroot.org> wrote:

> From 14cb284a085107a11c6d3636660e5a7ad5550a98 Mon Sep 17 00:00:00 2001
> From: Tudor Barbu <tudor.barbu@keysight.com>
> Date: Fri, 17 Dec 2021 14:51:20 +0200
> Subject: [PATCH 1/1] package/poco: bump version to 1.11.1
> 
> This version contains multiple bug fixes and introduces ActiveRecord
> 
> Removed: 0001-poco-add-the-staging-path-to-search-path.patch
> 
> Selecting custom mysql lib and include is now supported via the
> configure script
> 
> The following patches are integrated in upstream:
> 0002-Add-support-for-m68000-1856.patch
> 0003-Foundation-src-utils.h-backport-double-conversion-ch.patch
> 
> I have performed a test build for aarch64 with gcc10 without issues
> 
> Signed-off-by: Tudor Barbu <tudor.barbu@keysight.com>

Thanks for your patch. However, it got damaged along the way, could you
try to use "git send-email" for future patch submissions?

Also, with your patch applied, the following defconfig which builds
poco in a very basic configuration, fails to build.

Example configuration:

BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_POCO=y
# BR2_TARGET_ROOTFS_TAR is not set

Build failure:

In file included from include/Poco/SAX/SAXParser.h:23,
                 from include/Poco/DOM/DOMParser.h:22,
                 from src/DOMParser.cpp:15:
include/Poco/XML/ParserEngine.h:22:10: fatal error: expat.h: No such file or directory
   22 | #include <expat.h>
      |          ^~~~~~~~~
compilation terminated.

Could you have a look and submit an updated patch that addresses this
problem?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2021-12-24 18:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 11:48 [Buildroot] [PATCH 1/1] package/poco: bump version to 1.11.1 Tudor Barbu via buildroot
2021-12-24 18:04 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211224190407.1a29db0e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@buildroot.org \
    --cc=tudor.barbu@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox