From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Yunhao Tian <t123yh.xyz@gmail.com>
Cc: Adrian Perez de Castro <aperez@igalia.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11
Date: Sat, 25 Dec 2021 16:31:24 +0100 [thread overview]
Message-ID: <20211225153124.GS2603@scaer> (raw)
In-Reply-To: <20211225050854.1138268-1-t123yh.xyz@gmail.com>
Yunhao, All,
On 2021-12-25 13:08 +0800, Yunhao Tian spake thusly:
> Cage requires wlroots to be built with X11 enabled
> in order to enable XWayland, otherwise it will fail
> with error:
>
> "ERROR: Problem encountered: Cannot build Cage with
> XWayland support: wlroots has been built without it"
>
> Signed-off-by: Yunhao Tian <t123yh.xyz@gmail.com>
> ---
> package/cage/cage.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/cage/cage.mk b/package/cage/cage.mk
> index a661857a95..6f1046eb2f 100644
> --- a/package/cage/cage.mk
> +++ b/package/cage/cage.mk
> @@ -11,7 +11,7 @@ CAGE_LICENSE_FILES = LICENSE
> CAGE_DEPENDENCIES = host-pkgconf wlroots
> CAGE_CONF_OPTS = -Dman-pages=disabled
>
> -ifeq ($(BR2_PACKAGE_XORG7),y)
> +ifeq ($(BR2_PACKAGE_XORG7)$(BR2_PACKAGE_WLROOTS_X11),yy)
BR2_PACKAGE_WLROOTS_X11 already depends on BR2_PACKAGE_XORG7, so keeping
BR2_PACKAGE_XORG7 in this codition is redundant, so I dropped it.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> CAGE_CONF_OPTS += -Dxwayland=true
> else
> CAGE_CONF_OPTS += -Dxwayland=false
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-12-25 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-25 5:08 [Buildroot] [PATCH] package/cage: only enable XWayland if wlroots has X11 Yunhao Tian
2021-12-25 15:31 ` Yann E. MORIN [this message]
2021-12-25 16:16 ` Yunhao Tian
2022-01-24 17:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211225153124.GS2603@scaer \
--to=yann.morin.1998@free.fr \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=t123yh.xyz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox