Re: [Buildroot] [PATCH] utils/checkpackagelib/lib_mk.py: fix check for overridden variable

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Ricardo,

On Mon, 27 Dec 2021 07:45:00 -0300
ricardo.martincoski@gmail.com wrote:

> 20 |# https://www.mail-archive.com/lttng-dev@lists.lttng.org/msg12950.html
> 21 |LTTNG_LIBUST_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DUATOMIC_NO_LINK_ERROR"
> 22 |
> 23 |ifeq ($(BR2_PACKAGE_PYTHON),y)
> 24 |LTTNG_LIBUST_DEPENDENCIES += python
> 25 |LTTNG_LIBUST_CONF_OPTS += --enable-python-agent
> 26 |else ifeq ($(BR2_PACKAGE_PYTHON3),y)
> 27 |LTTNG_LIBUST_DEPENDENCIES += python3
> 28 |LTTNG_LIBUST_CONF_OPTS += --enable-python-agent
> 29 |else
> 30 |LTTNG_LIBUST_CONF_ENV = am_cv_pathless_PYTHON="none"
> 31 |LTTNG_LIBUST_CONF_OPTS += --disable-python-agent
> 32 |endif
> 
> Well, it seems that line 30 is indeed overriding line 21 when python is not
> enabled.
>
> As check-package is today, except for _DEPENDENCIES, all other variables can
> have either:
> 
> |ifeq (condition)
> |VAR_1 = value
> |endif
> 
> or:
> 
> |ifeq (condition)
> |VAR_1 += value
> |endif
> 
> check-package will only complain when there is an actual override:
> 
> |VAR_1 = value
> |ifeq (condition)
> |VAR_1 = value
> |endif

Aah, that is the part that I missed!

> We could, for instance, change it to always expect:
> 
> |ifeq (condition)
> |VAR_1 += value
> |endif
> 
> ... catching potential overrides.

Well, I just merged code that does this:

ifeq ($(BR2_ENDIAN),"BIG")
BENTO4_BYTE_ORDER = 0
else
BENTO4_BYTE_ORDER = 1
endif

and here we don't want to force a +=.

So I guess the current behavior of check-package is correct!

Thanks for the clarification!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot