Re: [Buildroot] [PATCH] package/rkdeveloptool: add new package

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Köry,

On Thu, 25 Nov 2021 16:50:40 +0100
Kory Maincent <kory.maincent@bootlin.com> wrote:

> This package is a tool from Rockchip to communicate with Rockusb devices.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

Thanks for this tool. I confirm that it builds fine with a container
that doesn't have udev development files installed. However, when I run
it, nothing happens:

$ ./host/bin/rkdeveloptool
$ ./host/bin/rkdeveloptool --help
$ ./host/bin/rkdeveloptool -h
$ ./host/bin/rkdeveloptool -v

Also, another problem is that it doesn't build with gcc 11.x:

main.cpp: In function ‘bool _Z9mergeBootv.part.0()’:
main.cpp:1493:43: error: ‘%s’ directive output may be truncated writing up to 557 bytes into a region of size 5 [-Werror=format-truncation=]
 1493 |         snprintf(buffer, sizeof(buffer), "%s", chip);
      |                                           ^~
......
 1534 |                 chipType = convertChipType(chip + 2);
      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~
main.cpp:1493:17: note: ‘snprintf’ output between 1 and 558 bytes into a destination of size 5
 1493 |         snprintf(buffer, sizeof(buffer), "%s", chip);
      |         ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:495: main.o] Error 1

Could you fix these issues, as well as add the license file hash as
spotted by Quentin ?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot