From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Peter Seiderer <ps.report@gmx.net>
Cc: buildroot@busybox.net,
Fabrice Fontaine <fontaine.fabrice@gmail.com>,
Maik Brenke <Maik.Brenke@continental-corporation.com>
Subject: Re: [Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure
Date: Thu, 30 Dec 2021 16:11:50 +0100 [thread overview]
Message-ID: <20211230161150.7b073fc6@windsurf> (raw)
In-Reply-To: <20200306201022.22382-1-ps.report@gmx.net>
Hello Peter,
On Fri, 6 Mar 2020 21:10:20 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> Add patch from upstream merge request ([1]) to fix fix gcc-8/gcc-9 snprintf
> truncation related compile failure (-Wall/-Werror), reported on the
> mailing list ([2]).
>
> Fixes:
>
> liboping.c: In function ‘ping_set_ttl’:
> liboping.c:207:9: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 242 [-Werror=format-truncation=]
> 207 | "%s: %s", function, message);
> | ^~
>
> [1] https://github.com/octo/liboping/pull/50
> [2] http://lists.busybox.net/pipermail/buildroot/2020-March/275861.html
>
> Reported-by: Maik Brenke <Maik.Brenke@continental-corporation.com>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> ...d-snprintf-truncation-warning-wError.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 package/liboping/0002-Mitigated-snprintf-truncation-warning-wError.patch
So I'm sorry, but the problem still didn't occur. I've tried using gcc
8.x and 9.x toolchains, haven't been able to see, and neither were the
autobuilders.
So for now, I'll mark this patch as Rejected, but if you have a
reproducer, we can certainly reconsider this.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-12-30 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 20:10 [Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure Peter Seiderer
2020-03-06 20:10 ` [Buildroot] [PATCH v1 2/3] package/liboping: add patch to fix utf8 ncurses support Peter Seiderer
2021-12-30 15:14 ` Thomas Petazzoni
2020-03-06 20:10 ` [Buildroot] [PATCH v1 3/3] package/liboping: add patch to fix suid root feature Peter Seiderer
2021-12-30 15:14 ` Thomas Petazzoni
2020-03-07 22:08 ` [Buildroot] [PATCH v1 1/3] package/liboping: add patch to fix gcc-8/gcc-9 snprintf truncation compile failure Thomas Petazzoni
2020-03-07 22:32 ` Peter Seiderer
2021-12-30 15:11 ` Thomas Petazzoni [this message]
2021-12-30 23:14 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230161150.7b073fc6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=Maik.Brenke@continental-corporation.com \
--cc=buildroot@busybox.net \
--cc=fontaine.fabrice@gmail.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox