Re: [Buildroot] [PATCH 15/16 v2] core/show-info: report package build steps and stamp files

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Thomas, All,

On 2021-12-30 21:46 +0100, Thomas Petazzoni spake thusly:
> On Sat, 13 Nov 2021 14:28:26 +0100
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > People (and their scripts!) whi want to report on the progress of the
> > build, will need to know what steps a package follows in what order.
> > 
> > This is handled internally by Buildroot itself already, by use of stamp
> > files.
> > 
> > However, the names of those stamp files are purely an implementation
> > detail (even if they are very unlikely to ever change).
[--SNIP--]
> This one I really found excessive. There's pretty a 1:1 relationship
> between the steps and the stamp files, so anything that has knowledge
> of the internal steps of a package can also know about the stamp files.

The thing is, those utilities do not even need to have the knowledge of
the internal steps, because the steps are all listed explicitly, in
order, with their names and associated stamp-files.

So, such a tool could just do (python-esque):

    for step in packages[pkg_name]['build_steps']:
        print('{}: {}'.format(step['step'], os.path.exists(step['stamp_file'])))

and they do not even have to concern themselves with whether we add or
remove steps, or whether we change the ordering or what.

(Yeah, the key for the step name could be changed from 'step' to 'name';
naming is hard.)

The only nitpick however, is that with TLPB, installation in images/ is
not ordered wrt the installation in target/ or staging/ (target/ is
always after staging/ even with TLPB).

Regards,
Yann E. MORIN.

> As it's more controversial than the rest of the series, I left it
> aside. I'll for now mark it as Rejected, but I'm also ready to revisit
> that if need be.
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot